From: "Suhail Singh" <suhailsingh247@gmail.com>
To: Omar Bassam <omar.bassam88@gmail.com>
Cc: Sharlatan Hellseher <sharlatanus@gmail.com>,
72925@debbugs.gnu.org, Munyoki Kilyungi <me@bonfacemunyoki.com>,
Katherine Cox-Buday <cox.katherine.e+guix@gmail.com>,
Guillaume Le Vaillant <glv@posteo.net>, jgart <jgart@dismail.de>
Subject: [bug#72925] Adding JPM package for Janet
Date: Wed, 18 Sep 2024 09:18:42 -0400 [thread overview]
Message-ID: <87h6adyua5.fsf_-_@gmail.com> (raw)
In-Reply-To: <950a7d3637ddf17be84f52dc2ae0aac2ce4c4be6.1725547778.git.omar.bassam88@gmail.com> (Omar Bassam's message of "Thu, 5 Sep 2024 17:50:02 +0300")
Hi Omar,
Thank you for submitting this patch. A few comments:
Omar Bassam <omar.bassam88@gmail.com> writes:
> Change-Id: I730ef2f5c874c5142a580a42af76180e95d93ccd
> ---
> gnu/packages/lisp.scm | 52 +++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 52 insertions(+)
>
> diff --git a/gnu/packages/lisp.scm b/gnu/packages/lisp.scm
> index 5d4399f145..96698d375d 100644
Could you please update the reroll-count when you send amendments to the
patch? IIUC, this version should have been v2.
> +(define-public jpm
> + (package
> + (name "jpm")
> + (version "1.1.0")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/janet-lang/jpm.git")
> + (commit (string-append "v" version))))
> + (file-name (git-file-name name version))
> + (sha256 (base32 "05rdxigmiy7vf93s16a8n2029lq33073jccz1rjl4iisxj6piw4l"))))
> + (build-system trivial-build-system)
> ...
> + (substitute* (string-append %output "/bin/jpm")
> + (("/usr/bin/env janet")
> + (string-append #$janet "/bin/janet")))
Is my understanding correct that you're updating the shebang line here?
If so, would it be better to use the copy-build-system instead? If not,
could you please elaborate? If copy-build-system does indeed turn out
to be better suited, could you please send v3 of the patch?
--
Suhail
next prev parent reply other threads:[~2024-09-18 13:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 8:31 [bug#72925] Adding JPM package for Janet Omar Bassam
2024-09-04 8:22 ` [bug#72925] [PATCH] adding jpm package Omar Bassam
2024-09-05 14:50 ` Omar Bassam
2024-09-18 13:18 ` Suhail Singh [this message]
2024-09-18 15:34 ` [bug#72925] Adding JPM package for Janet Omar Bassam
2024-09-18 16:16 ` Suhail Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6adyua5.fsf_-_@gmail.com \
--to=suhailsingh247@gmail.com \
--cc=72925@debbugs.gnu.org \
--cc=cox.katherine.e+guix@gmail.com \
--cc=glv@posteo.net \
--cc=jgart@dismail.de \
--cc=me@bonfacemunyoki.com \
--cc=omar.bassam88@gmail.com \
--cc=sharlatanus@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.