all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Sharlatan Hellseher <sharlatanus@gmail.com>
To: 74680-done@debbugs.gnu.org
Subject: bug#74680: [PATCH] gnu: Add python-scikit-surprise.
Date: Wed, 04 Dec 2024 14:37:30 +0000	[thread overview]
Message-ID: <87h67j8qfp.fsf@gmail.com> (raw)
In-Reply-To: <877c8gjp6q.fsf@antr.me>

[-- Attachment #1: Type: text/plain, Size: 3257 bytes --]


Hi,

Thank you for the patch!

I've checked the license, built it on the latest master HEAD and applied some
styling modifications:

--8<---------------cut here---------------start------------->8---
@@ -604,31 +604,41 @@ (define-public python-scikit-surprise
   (package
     (name "python-scikit-surprise")
     (version "1.1.4")
-    (source (origin
-              (method git-fetch)
-              (uri (git-reference
-                    (url "https://github.com/NicolasHug/Surprise")
-                    (commit (string-append "v" version))))
-              (file-name (git-file-name name version))
-              (sha256
-               (base32
-                "15ckx2i41vs21sa3yqyj12zr0h4zrcdf3lrwcy2c1cq2bjq7mnvz"))))
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/NicolasHug/Surprise")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "15ckx2i41vs21sa3yqyj12zr0h4zrcdf3lrwcy2c1cq2bjq7mnvz"))))
     (build-system pyproject-build-system)
     (arguments
      (list
-      #:phases #~(modify-phases %standard-phases
-                   (add-before 'check 'change-home-dir
-                     (lambda _
-                       ;; Change from /homeless-shelter to /tmp for write
-                       ;; permission.
-                       (setenv "HOME" "/tmp"))))))
-    (native-inputs (list python-cython python-pandas python-pytest))
-    (propagated-inputs (list python-joblib python-numpy python-scikit-learn))
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-before 'check 'set-home
+            (lambda _
+              ;; Change from /homeless-shelter to /tmp for write
+              ;; permission.
+              (setenv "HOME" "/tmp"))))))
+    (native-inputs
+     (list python-cython-3
+           python-pandas
+           python-pytest
+           python-setuptools
+           python-wheel))
+    (propagated-inputs
+     (list python-joblib
+           python-numpy
+           python-scikit-learn))
     (home-page "https://surpriselib.com/")
     (synopsis "Recommender system library for Scikit-learn")
-    (description "This package provides a Python library for building and
-analyzing recommender systems that deal with explicit rating data.  It was
-designed with the following purposes in mind:
+    (description
+     "This package provides a Python library for building and analyzing
+recommender systems that deal with explicit rating data.  It was designed with
+the following purposes in mind:
 @itemize
 @item Provide tools to handle downloaded or user-provided datasets.
 @item Provide ready-to-use prediction algorithms and similarity measures.e
--8<---------------cut here---------------end--------------->8---

Pusshed as
--8<---------------cut here---------------start------------->8---
master local/20241204095328-issue-74680 16c71b7fe328a159f6e6d13b42ee23b448465905
Author:     Antero Mejr <mail@antr.me>
AuthorDate: Tue Dec 3 18:56:45 2024 -0500
Commit:     Sharlatan Hellseher <sharlatanus@gmail.com>
CommitDate: Wed Dec 4 14:28:10 2024 +0000
--8<---------------cut here---------------end--------------->8---

--
Oleg

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply	other threads:[~2024-12-04 14:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03 23:56 [bug#74680] [PATCH] gnu: Add python-scikit-surprise Antero Mejr
2024-12-04 14:37 ` Sharlatan Hellseher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h67j8qfp.fsf@gmail.com \
    --to=sharlatanus@gmail.com \
    --cc=74680-done@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.