From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add IceCat.
Date: Mon, 11 Nov 2013 22:34:36 +0100
Message-ID: <87fvr2hbbn.fsf@gnu.org>
References: <20131111194739.GA27236@debian>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57164)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Vfz89-0003fQ-F7
	for guix-devel@gnu.org; Mon, 11 Nov 2013 16:34:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Vfz83-0000aQ-2B
	for guix-devel@gnu.org; Mon, 11 Nov 2013 16:34:45 -0500
Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:16729)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Vfz82-0000aK-Rp
	for guix-devel@gnu.org; Mon, 11 Nov 2013 16:34:38 -0500
In-Reply-To: <20131111194739.GA27236@debian> (Andreas Enge's message of "Mon,
	11 Nov 2013 20:47:39 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Andreas Enge <andreas@enge.fr>
Cc: guix-devel@gnu.org

Andreas Enge <andreas@enge.fr> skribis:

> See the attached patch. Comments welcome. Do I miss any interesting input=
s?

Excellent!

> +(define-public icecat
> +  (package
> +    (name "icecat")
> +    (version "24.0")
> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "mirror://gnu/gnuzilla/"
> +                          (string-copy version 0 (string-index version #=
\.))

Perhaps =E2=80=98substring=E2=80=99 instead of =E2=80=98string-copy=E2=80=
=99 (does pretty much the same
thing, but the meaning is clearer IMO.)

> +          (lambda* (#:key #:allow-other-keys)

(lambda _ ...) is enough (where =E2=80=98_=E2=80=99 is a convention to sugg=
est that we
don=E2=80=99t care about the arguments.)

> +            ;; delete dangling symlinks

Do they cause problem with one of the patch-everything passes?

Other than that, it looks good to me.

Thanks for this brave endeavor!

Ludo=E2=80=99.