[PATCH] gnu: add libglade

[PATCH] gnu: add libglade

[ggrant]

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

Hoping to gradually get back into packaging some stuff of interest. Here's
libglade for now, if anything looks wrong be sure to let me know. :^)

[-- Attachment #2: 0001-gnu-Add-libglade.patch --]
[-- Type: application/octet-stream, Size: 1984 bytes --]

From 58b053edfabd89b5c9da034b295791ceb1cf1281 Mon Sep 17 00:00:00 2001
From: Guy Grant <ggrant@riseup.net>
Date: Thu, 27 Feb 2014 17:46:06 -0600
Subject: [PATCH] gnu: Add libglade

---
 gnu/packages/gtk.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 2a01f89..353c7ef 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2013 Andreas Enge <andreas@enge.fr>
 ;;; Copyright © 2013 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2014 Guy Grant <ggrant@riseup.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -308,6 +309,34 @@ is part of the GNOME accessibility project.")
    (license license:lgpl2.0+)
    (home-page "https://projects.gnome.org/accessibility/")))
 
+(define-public libglade
+  (package
+    (name "libglade")
+    (version "2.6.4")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append
+                   "http://ftp.gnome.org/pub/GNOME/sources/libglade/2.6/libglade-"
+                   version
+                   ".tar.gz"))
+             (sha256
+              (base32
+               "1lxdjx87r2zvdp5pg00xidfhg0y12in8vr3kj037cya5d2dih7f4"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("gtk+-2" ,gtk+-2)
+       ("libxml2" ,libxml2)
+       ("python" ,python-2)))
+    (native-inputs
+      `(("pkg-config" ,pkg-config)))
+    (home-page "https://developer.gnome.org/libglade/")
+    (synopsis "Allows you to load glade interface files in a program at runtime")
+    (description
+     "Libglade is a library that provides interfaces for loading graphical interfaces 
+described in glade xml files and for accessing the widgets built in the loading process, 
+.glade files are generated by the Glade application.")
+    (license license:lgpl2.0)))
+
 (define-public gtk+-2
   (package
    (name "gtk+")
-- 
1.8.5.3

Re: [PATCH] gnu: add libglade

[Ludovic Courtès]

ggrant@riseup.net skribis:

> +(define-public libglade
> +  (package
> +    (name "libglade")
> +    (version "2.6.4")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "http://ftp.gnome.org/pub/GNOME/sources/libglade/2.6/libglade-"

There’s Glade 3.8 in gnome.scm; is it a different thing?

Thanks,
Ludo’.

Re: [PATCH] gnu: add libglade

[ggrant]

> ggrant@riseup.net skribis:
>
>> +(define-public libglade
>> +  (package
>> +    (name "libglade")
>> +    (version "2.6.4")
>> +    (source (origin
>> +             (method url-fetch)
>> +             (uri (string-append
>> +
>> "http://ftp.gnome.org/pub/GNOME/sources/libglade/2.6/libglade-"
>
> There’s Glade 3.8 in gnome.scm; is it a different thing?
>
> Thanks,
> Ludo’.
>

Yeah, I believe it's different. This is for GTK+2.x, not 3.x. It's mostly
deprecated, but still used in a number of places that have yet to upgrade
to it (GTK+3).

Re: [PATCH] gnu: add libglade

[Ludovic Courtès]

ggrant@riseup.net skribis:

> Hoping to gradually get back into packaging some stuff of interest. Here's
> libglade for now, if anything looks wrong be sure to let me know. :^)

OK, so here’s a proper review, on the assumption that it’s needed.

> From 58b053edfabd89b5c9da034b295791ceb1cf1281 Mon Sep 17 00:00:00 2001
> From: Guy Grant <ggrant@riseup.net>
> Date: Thu, 27 Feb 2014 17:46:06 -0600
> Subject: [PATCH] gnu: Add libglade

Please add a proper commit log.

> +(define-public libglade
> +  (package
> +    (name "libglade")
> +    (version "2.6.4")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append
> +                   "http://ftp.gnome.org/pub/GNOME/sources/libglade/2.6/libglade-"
> +                   version
> +                   ".tar.gz"))

Use mirror://gnome.

> +    (synopsis "Allows you to load glade interface files in a program at runtime")

Rather something like “Load GTK+2 Glade interface files at run time”, WDYT?

> +    (description
> +     "Libglade is a library that provides interfaces for loading graphical interfaces 
> +described in glade xml files and for accessing the widgets built in the loading process, 
> +.glade files are generated by the Glade application.")
> +    (license license:lgpl2.0)))

I guess it’s v2.0-or-any-later-version, no?  (Or even 2.1.)  Could you
check that?  If that is the case, then use license:lgpl2.0+.

Could you send an updated patch?

Thanks!

Ludo’.