From: ludo@gnu.org (Ludovic Courtès)
To: Manolis Ragkousis <manolis837@gmail.com>
Cc: Guix-devel@gnu.org
Subject: Re: Problem with (patches)
Date: Sat, 12 Apr 2014 11:57:29 +0200 [thread overview]
Message-ID: <87fvli50qe.fsf@gnu.org> (raw)
In-Reply-To: <CAFtzXzNG7pRW8KreAogAKfeu_4STCVOh8vO46+geTu1-GU00jw@mail.gmail.com> (Manolis Ragkousis's message of "Fri, 11 Apr 2014 23:50:33 +0000")
[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]
Manolis Ragkousis <manolis837@gmail.com> skribis:
> In this part of my code
>> (source (origin
>> (method git-fetch)
>> (uri (git-reference
>> (url "git://git.savannah.gnu.org/hurd/hurd")
>> (commit "e77f00db5097d741f27c74c03d194a233f648615")))
>> (sha256
>> (base32
>> "010q5wy88gaw4qfv2vl9pxfma9px8gs6v03ahqksq420v003b6r1"))
>> (patches (list (search-patch "minimal-hurd.patch")))))
>
> as long as I have (patches..) in there I get the error here
>
> http://paste.lisp.org/display/142007/raw
(Please always put things inline.)
--8<---------------cut here---------------start------------->8---
549: 5 [expand-input # # # ...]
512: 4 [cache # "x86_64-linux" #<procedure thunk ()>]
602: 3 [thunk]
320: 2 [patch-and-repack # # # ...]
In ice-9/boot-9.scm:
357: 1 [string-every #<charset {#\0..#\9 #\A..#\F #\a..#\f}> #f 0 #<undefined>]
In unknown file:
?: 0 [string-length #f]
--8<---------------cut here---------------end--------------->8---
I believe this is fixed with:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 562 bytes --]
diff --git a/guix/packages.scm b/guix/packages.scm
index 812d6bb..fa93cee 100644
--- a/guix/packages.scm
+++ b/guix/packages.scm
@@ -317,7 +317,8 @@ IMPORTED-MODULES specify modules to use/import for use by SNIPPET."
(define (numeric-extension? file-name)
;; Return true if FILE-NAME ends with digits.
- (string-every char-set:hex-digit (file-extension file-name)))
+ (and=> (file-extension file-name)
+ (string-every char-set:hex-digit <>)))
(define (tarxz-name file-name)
;; Return a '.tar.xz' file name based on FILE-NAME.
[-- Attachment #3: Type: text/plain, Size: 865 bytes --]
Can you confirm?
In addition, you may want to add a ‘file-name’ field, so that the
checkout has a name more descriptive than ‘git-checkout’, as is done for
libwebsockets:
(package
(name "libwebsockets")
(version "1.2")
(source (origin
;; The project does not publish tarballs, so we have to take
;; things from Git.
(method git-fetch)
(uri (git-reference
(url "git://git.libwebsockets.org/libwebsockets")
(commit (string-append "v" version
"-chrome26-firefox18"))))
(sha256
(base32
"1293hbz8qj4p27m1qjf8dn97r10xjyiwdpq491m87zi025s558cl"))
(file-name (string-append name "-" version)))) ;; <--- here
HTH!
Ludo’.
next prev parent reply other threads:[~2014-04-12 9:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 23:50 Problem with (patches) Manolis Ragkousis
2014-04-12 8:45 ` Manolis Ragkousis
2014-04-12 9:57 ` Ludovic Courtès [this message]
2014-04-12 12:08 ` Manolis Ragkousis
2014-04-12 12:40 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvli50qe.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=Guix-devel@gnu.org \
--cc=manolis837@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.