From: ludo@gnu.org (Ludovic Courtès)
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>
Subject: Re: [PATCH] gnu: Make gtk-glext depend on pangox-compat and remove workaround patch
Date: Wed, 28 May 2014 15:20:12 +0200 [thread overview]
Message-ID: <87fvjuf3ar.fsf@gnu.org> (raw)
In-Reply-To: <20140528111728.GA21965@jocasta.intra> (John Darrington's message of "Wed, 28 May 2014 13:17:28 +0200")
John Darrington <john@darrington.wattle.id.au> skribis:
> On Wed, May 28, 2014 at 01:12:59PM +0200, John Darrington wrote:
> On Wed, May 28, 2014 at 11:57:28AM +0200, Ludovic Court??s wrote:
> Hi John,
>
> Could you make it two separate patches? Why is the patch no longer
> needed?
>
> The patch is no longer needed because of the new dependency. I guess I could
> make it two changes, but in my opinion, they belong together.
>
> BTW. Both of your questions are a good example of why I believe the *reason*
> for a change is far more useful in a commit message, than the details
> of what has changed (which is redundant anyway, since it could be seen by
> running "git diff").
In this case, it makes sense to mention in the commit log the reason for
the change.
As for the general case, we’ll stick to
<http://www.gnu.org/prep/standards/html_node/Change-Logs.html>. The
rationale still holds.
Ludo’.
next prev parent reply other threads:[~2014-05-28 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 7:18 [PATCH] gnu: Make gtk-glext depend on pangox-compat and remove workaround patch John Darrington
2014-05-28 9:57 ` Ludovic Courtès
2014-05-28 11:12 ` John Darrington
2014-05-28 11:17 ` John Darrington
2014-05-28 13:20 ` Ludovic Courtès [this message]
2014-05-28 13:18 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fvjuf3ar.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
--cc=john@darrington.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.