From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add xboing
Date: Mon, 13 Oct 2014 15:54:50 +0200
Message-ID: <87fvescbx1.fsf@gnu.org>
References: <1413196628-2461-1-git-send-email-jmd@gnu.org>
	<87wq84cfy3.fsf@gnu.org> <20141013124302.GA11097@jocasta.intra>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42108)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Xdg5I-0003fP-I7
	for guix-devel@gnu.org; Mon, 13 Oct 2014 09:54:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Xdg5D-00044h-PW
	for guix-devel@gnu.org; Mon, 13 Oct 2014 09:54:48 -0400
In-Reply-To: <20141013124302.GA11097@jocasta.intra> (John Darrington's message
	of "Mon, 13 Oct 2014 14:43:03 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>

John Darrington <john@darrington.wattle.id.au> skribis:

> On Mon, Oct 13, 2014 at 02:27:48PM +0200, Ludovic Court??s wrote:
>      John Darrington <jmd@gnu.org> skribis:
>=20=20=20=20=20=20
>      > * gnu/packages/games.scm (xboing): New variable.
>
>      [...]
>=20=20=20=20=20=20
>      > +    (inputs `(("libx11" ,libx11)
>      > +	      ("libxext" ,libxext)
>      > +	      ("libxpm" ,libxpm)))
>      > +    (native-inputs `(("imake" ,imake)
>      > +		     ("inetutils" ,inetutils)
>      > +		     ("makedepend" ,makedepend)))
>=20=20=20=20=20=20
>      Please align opening parenthesis and use only spaces, no tabs (for E=
macs
>      23 and later, .dir-locals.el normally sets it up.)
>
> This was formatted by emacs using indent-region.  Shouldn't that do the j=
ob?
> loading .dir-locals.el results in an error for me.

Emacs 23+ loads it automatically.  Otherwise, drop:

  (setq indent-tabs-mode nil)

somewhere in ~/.emacs.

>      > +    (license x11-style)))
>=20=20=20=20=20=20
>      ???x11-style??? is a procedure, so it should be:
>=20=20=20=20=20=20
>        (x11-style URI [COMMENT])
>=20=20=20=20=20=20
>      Make sure it???s not really ???x11??? or ???expat???.
>
> It is neither of those, although similar.  The trouble is, I don't think =
that=20
> there is a URI for the license.  It is contained in the tarball.

See other uses: it=E2=80=99s fine to use file://COPYING, say, as the URI to=
 the
license, if the only copy is within the tarball.

Also, it=E2=80=99s even better if you can add a comment above saying what=
=E2=80=99s
different from the X11 license text.

Thanks,
Ludo=E2=80=99.