From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] guix: scripts: Fix GUIX_BUILD_OPTIONS handling.
Date: Sat, 06 Dec 2014 16:04:43 +0100
Message-ID: <87fvcszuno.fsf@gnu.org>
References: <CAJ41eeyECrUPfEhS+9puU3y0iczEeCs8JgKB8RnTRofVNOW_4w@mail.gmail.com>
	<CAJ41eewKNWaw8ufRS3N6CdrK7j=isv7LKhSh3J0oUVSv8DxBUA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59559)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XxGun-0002PW-3O
	for guix-devel@gnu.org; Sat, 06 Dec 2014 10:05:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1XxGuc-0007Kk-Qk
	for guix-devel@gnu.org; Sat, 06 Dec 2014 10:04:57 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:49756)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1XxGuc-0007Jf-JE
	for guix-devel@gnu.org; Sat, 06 Dec 2014 10:04:46 -0500
In-Reply-To: <CAJ41eewKNWaw8ufRS3N6CdrK7j=isv7LKhSh3J0oUVSv8DxBUA@mail.gmail.com>
	(Deck Pickard's message of "Fri, 5 Dec 2014 01:53:51 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Deck Pickard <deck.r.pickard@gmail.com>
Cc: guix-devel@gnu.org

Deck Pickard <deck.r.pickard@gmail.com> skribis:

> From 9c27d995e1a622de8457209d40031b392538e0f8 Mon Sep 17 00:00:00 2001
> From: nebuli <nebu@kipple>
> Date: Fri, 5 Dec 2014 01:28:12 +0100
> Subject: [PATCH] guix: scripts: Fix GUIX_BUILD_OPTIONS handling.
>
> Appending to "raw" args broke optional parameters in 'guix package -I'
> and 'guix package -A', and possibly other places.  Therefore, switch to
> parsing each set of options on its own and append resulting alists
> together afterwards.
>
> * guix/scripts/archive.scm (parse-options-from): Rename from
>   (parse-options) and add explicit argument.  New form of (parse-options)
>   using its old algorithm via -from function.
> * guix/scripts/build.scm: Ditto.
> * guix/scripts/environment.scm: Ditto.
> * guix/scripts/package.scm: Ditto.
> * guix/scripts/system.scm: Ditto.

Good catch.  I=E2=80=99ve applied it along with a test case that reproduces=
 the
problem and a clarification in the doc.

Thanks!

Ludo=E2=80=99.