From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark H Weaver <mhw@netris.org>
Subject: Re: [PATCH] gnu: Add bedtools
Date: Sat, 13 Dec 2014 01:42:59 -0500
Message-ID: <87fvckyrrg.fsf@netris.org>
References: <idj388lkwih.fsf@bimsb-sys02.mdc-berlin.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39677)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1XzgPf-0007eF-LI
	for guix-devel@gnu.org; Sat, 13 Dec 2014 01:42:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1XzgPZ-0005qE-Ko
	for guix-devel@gnu.org; Sat, 13 Dec 2014 01:42:47 -0500
Received: from world.peace.net ([50.252.239.5]:35647)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mhw@netris.org>) id 1XzgPZ-0005qA-Gb
	for guix-devel@gnu.org; Sat, 13 Dec 2014 01:42:41 -0500
In-Reply-To: <idj388lkwih.fsf@bimsb-sys02.mdc-berlin.net> (Ricardo Wurmus's
	message of "Fri, 12 Dec 2014 11:11:50 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org

Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> writes:

> From c8d71da303ff6b82a30db542d382cab57a00699e Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
> Date: Thu, 11 Dec 2014 17:37:16 +0100
> Subject: [PATCH] gnu: Add bedtools

Ludovic mostly covered this, but I have two additional suggestions:

> +                 (alist-replace
> +                  'install (lambda* (#:key outputs #:allow-other-keys)

Please align the lambda* under 'install.

> +                             (let* ((out (assoc-ref outputs "out"))
> +                                    (bin (string-append out "/bin"))
> +                                    (tools
> +                                     '("bamToFastq" "mapBed" "shuffleBed" "bed12ToBed6" "bedToBam"
> +                                       "multiIntersectBed" "complementBed" "randomBed" "tagBam" "sortBed"
> +                                       "annotateBed" "clusterBed" "fastaFromBed" "coverageBed" "bedpeToBam"
> +                                       "pairToPair" "subtractBed" "nucBed" "expandCols" "bedToIgv" "slopBed"
> +                                       "closestBed" "windowMaker" "linksBed" "getOverlap" "mergeBed" "windowBed"
> +                                       "flankBed" "pairToBed" "intersectBed" "bamToBed" "multiBamCov"
> +                                       "unionBedGraphs" "genomeCoverageBed" "groupBy" "maskFastaFromBed"
> +                                       "bedtools")))
> +                               (mkdir-p bin)
> +                               (map (lambda (tool)

It would be more appropriate to use 'for-each' here instead of 'map'.

> +                                      (copy-file (string-append "bin/" tool)
> +                                                 (string-append bin "/" tool)))
> +                                    tools)))
> +                  %standard-phases)))))
[...]

    Thanks!
      Mark