From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Kost <alezost@gmail.com>
Subject: Re: [PATCH] gnu: Add xdotool.
Date: Sun, 14 Dec 2014 18:14:57 +0300
Message-ID: <87fvciw9e6.fsf@gmail.com>
References: <1418554100-10329-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49235)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1Y0At2-0001qq-Sx
	for guix-devel@gnu.org; Sun, 14 Dec 2014 10:15:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alezost@gmail.com>) id 1Y0Asw-0002qA-PB
	for guix-devel@gnu.org; Sun, 14 Dec 2014 10:15:08 -0500
In-Reply-To: <1418554100-10329-1-git-send-email-jmd@gnu.org> (John
	Darrington's message of "Sun, 14 Dec 2014 11:48:20 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

I've tried this patch and it has been built successfully on my i686 machine.

So only nitpickings from me.

John Darrington (2014-12-14 13:48 +0300) wrote:

[...]
> +    (arguments
> +     '(#:tests? #f ; Test suite requires a lot of black magic
> +       #:phases=20
Trailing space    =E2=86=91
> +       (alist-replace 'configure=20
Another one                        =E2=86=91
> +                      (lambda* (#:key outputs #:allow-other-keys #:rest =
args)
> +                        (setenv "PREFIX" (assoc-ref outputs "out"))
> +                        (setenv "LDFLAGS"  (string-append "-Wl,-rpath=3D"
Double space                                =E2=86=91=E2=86=91
> +                                                        (assoc-ref %outp=
uts "out") "/lib"))
Not aligned properly and this line is too long             =E2=86=91
> +
> +                        (setenv "CC" "gcc"))
> +                      %standard-phases)))
> +    (native-inputs `(("perl" ,perl))) ; for pod2man
> +    (inputs `(("libx11" ,libx11)
> +              ("libxext" ,libxext)
> +              ("libxi" ,libxi)
> +              ("libxinerama" ,libxinerama)
> +              ("libxtst" ,libxtst)))
> +    (home-page "http://www.semicomplete.com/projects/xdotool")
> +    (synopsis "Fake keyboard/mouse input, window management, and more")
> +    (description "Xdotool lets you simulate keyboard input and mouse act=
ivity,
> +move and resize windows, etc. It does this using X11's XTEST extension a=
nd
Single space                    =E2=86=91
> +other Xlib functions.  Additionally, you can search for windows and move,
> +resize, hide, and modify window properties like the title. If your window
Single space                                                 =E2=86=91
> +manager supports it, you can use xdotool to switch desktops, move windows
> +between desktops, and change the number of desktops.")
> +    (license license:bsd-3)))

IIUC using double spaces in the end of sentences is a convention.  Also
I noticed that you make descriptions look like this:

  (description "=E2=80=A6")

This makes the first line significantly shorter than other ones, so some
people (including me) prefer the following variant:

  (description
   "=E2=80=A6")

What about making a convention on how "description" fields should look.
Ludo?

--=20
Alex