From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add ninja.
Date: Fri, 09 Jan 2015 15:34:25 +0100
Message-ID: <87fvbk3tvy.fsf@gnu.org>
References: <1420810817-23613-1-git-send-email-iyzsong@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54480)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y9ae0-0005xE-8R
	for guix-devel@gnu.org; Fri, 09 Jan 2015 09:34:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1Y9adx-0001Zl-18
	for guix-devel@gnu.org; Fri, 09 Jan 2015 09:34:32 -0500
Received: from hera.aquilenet.fr ([2a01:474::1]:33937)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1Y9adw-0001Ze-R1
	for guix-devel@gnu.org; Fri, 09 Jan 2015 09:34:28 -0500
In-Reply-To: <1420810817-23613-1-git-send-email-iyzsong@gmail.com>
	(=?utf-8?B?IuWui+aWh+atpiIncw==?=
	message of "Fri, 9 Jan 2015 21:40:17 +0800")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Cc: guix-devel@gnu.org

=E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:

> * gnu/packages/ninja.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

[...]

> +          'check
> +          (lambda _
> +            (and (zero? (system "./configure.py"))
> +                 (zero? (system "./ninja ninja_test"))
> +                 ;; SubprocessTest.InterruptChild fail when using 'syste=
m*'.
> +                 ;; SubprocessTest.SetWithLots was skipped.
> +                 ;; XXX: Raise [ulimit -n] well above 1025 to make this =
test go.

Does it mean that the test is currently failing?

> +                 (zero? (system (string-append
> +                                 "./ninja_test "
> +                                 "--gtest_filter=3D"
> +                                 "-SubprocessTest.SetWithLots")))))

Please use =E2=80=98system*=E2=80=99 (with separate arguments) rather than =
=E2=80=98system=E2=80=99.
The latter runs =E2=80=9C/bin/sh -c ...=E2=80=9D whereas the former runs th=
e program
directly.

Thanks,
Ludo=E2=80=99.