From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add libsbsms.
Date: Tue, 24 Feb 2015 23:52:58 +0100
Message-ID: <87fv9u9b1x.fsf@gnu.org>
References: <87lhjqluob.fsf@taylan.uni.cx> <878ufqluj0.fsf@taylan.uni.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34416)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YQOLg-0000ni-AU
	for guix-devel@gnu.org; Tue, 24 Feb 2015 17:53:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1YQOLd-00038m-3n
	for guix-devel@gnu.org; Tue, 24 Feb 2015 17:53:04 -0500
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41778)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1YQOLc-00038i-VH
	for guix-devel@gnu.org; Tue, 24 Feb 2015 17:53:00 -0500
In-Reply-To: <878ufqluj0.fsf@taylan.uni.cx> ("Taylan Ulrich
	\=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\=
	message of "Sun, 22 Feb 2015 00:22:27 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Taylan Ulrich =?utf-8?Q?=22Bay=C4=B1rl=C4=B1?=
	=?utf-8?Q?=2FKammer=22?= <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org

taylanbayirli@gmail.com (Taylan Ulrich "Bay=C4=B1rl=C4=B1/Kammer") skribis:

> From 7aed4cd0b6bd365e31fe5fb6de1c7249ca300e15 Mon Sep 17 00:00:00 2001
> From: =3D?UTF-8?q?Taylan=3D20Ulrich=3D20Bay=3DC4=3DB1rl=3DC4=3DB1/Kammer?=
=3D
>  <taylanbayirli@gmail.com>
> Date: Fri, 20 Feb 2015 21:42:48 +0100
> Subject: [PATCH 4/9] gnu: Add libsbsms.
>
> * gnu/packages/audio.scm (libsbsms): New variable.

[...]

> +        (lambda* (#:key inputs #:allow-other-keys)
> +          ;; Originally a symlink to '/usr/local/share/automake-1.12/ar-=
lib'.
> +          (delete-file "ar-lib")
> +          (symlink
> +           (string-append (assoc-ref inputs "automake") "/share/automake=
-"
> +                          ,(package-version automake) "/ar-lib")
> +           "ar-lib"))

I think it could just run =E2=80=9Cautomake --add-missing=E2=80=9D instead,=
 which is
lightly more elegant and future-proof.

Other than that LGTM, thanks!

Ludo=E2=80=99.