From: ludo@gnu.org (Ludovic Courtès)
To: "Taylan Ulrich \"Bayırlı/Kammer\"" <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add libsbsms.
Date: Tue, 24 Feb 2015 23:52:58 +0100 [thread overview]
Message-ID: <87fv9u9b1x.fsf@gnu.org> (raw)
In-Reply-To: <878ufqluj0.fsf@taylan.uni.cx> ("Taylan Ulrich \=\?utf-8\?Q\?\=5C\=22Bay\=C4\=B1rl\=C4\=B1\=2FKammer\=5C\=22\=22's\?\= message of "Sun, 22 Feb 2015 00:22:27 +0100")
taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") skribis:
> From 7aed4cd0b6bd365e31fe5fb6de1c7249ca300e15 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
> <taylanbayirli@gmail.com>
> Date: Fri, 20 Feb 2015 21:42:48 +0100
> Subject: [PATCH 4/9] gnu: Add libsbsms.
>
> * gnu/packages/audio.scm (libsbsms): New variable.
[...]
> + (lambda* (#:key inputs #:allow-other-keys)
> + ;; Originally a symlink to '/usr/local/share/automake-1.12/ar-lib'.
> + (delete-file "ar-lib")
> + (symlink
> + (string-append (assoc-ref inputs "automake") "/share/automake-"
> + ,(package-version automake) "/ar-lib")
> + "ar-lib"))
I think it could just run “automake --add-missing” instead, which is
lightly more elegant and future-proof.
Other than that LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2015-02-24 22:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-21 23:19 [PATCH] gnu: Add libsbsms Taylan Ulrich Bayırlı/Kammer
2015-02-21 23:22 ` Taylan Ulrich Bayırlı/Kammer
2015-02-24 17:32 ` Taylan Ulrich Bayırlı/Kammer
2015-02-24 22:52 ` Ludovic Courtès [this message]
2015-02-24 23:23 ` Taylan Ulrich Bayırlı/Kammer
2015-02-25 14:03 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fv9u9b1x.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=taylanbayirli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.