From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] Add Csound and Solfege. Date: Fri, 03 Apr 2015 16:33:43 +0200 Message-ID: <87fv8hjn7c.fsf@gnu.org> References: <87twx03mxf.fsf@mango.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36131) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye2fR-0002Jd-7D for guix-devel@gnu.org; Fri, 03 Apr 2015 10:33:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ye2fM-0001LN-0k for guix-devel@gnu.org; Fri, 03 Apr 2015 10:33:53 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ye2fL-0001LJ-Ui for guix-devel@gnu.org; Fri, 03 Apr 2015 10:33:47 -0400 In-Reply-To: <87twx03mxf.fsf@mango.localdomain> (Ricardo Wurmus's message of "Tue, 31 Mar 2015 22:57:16 +0200") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: Guix-devel Ricardo Wurmus skribis: > patch-python-shebangs > : Self-explanatory. As at least one file is in ISO-8859 encoding this > whole thing is wrapped in (with-fluids ((%default-port-encoding #f)) > ...) Why doesn=E2=80=99t the =E2=80=98patch-shebangs=E2=80=99 phase do its job? = Could =E2=80=98patch-shebang=E2=80=99 be used instead of =E2=80=98substitute*=E2= =80=99? > add-sitedirs > : This is something I think will be required for many pygtk-based > applications. As *.pth files are not automatically considered, > dependencies of pygtk are not loaded and thus not found unless the > directories containing the *.pth files are added as sites. I think > it would be better if we could find a way around patching each and > every PyGTK application in this ad-hoc manner. Yeah. > adjust-config-file-prefix > : Config files are usually loaded from /etc or /usr/share. This > phase sets the prefix to the package output directory. OK. I suppose Solfege also supports reading per-user config files from ~/.config or similar? > fix-gettext > : I have no idea what's wrong with the i18n of Solfege. Upon > application start I'm greeted with locale errors and this particular > line looks like just wrong. "i18n" is None at this point and the > application just crashes unless I comment the line. I feel least > comfortable with this hack and I'd be glad if someone could find a > fix that makes this phase obsolete. I don=E2=80=99t know what the Python API looks like. The gettext manual mentions an API with the =E2=80=98gettext.=E2=80=99 prefix, dunno if that= =E2=80=99s a different thing. > Despite all these hacks and fixes, Solfege exhibits somewhat odd > behaviour. Sometimes an empty window pops up, accompanied by a timer > error message on the command line: > > /gnu/store/...-solfege-3.22.2/share/solfege/solfege/gu.py:334: Warning= : Source ID 3071 was not found when attempting to remove it > gobject.source_remove(self.__timeout) > > I suspect some of these issues should be reported upstream because it > seems that they have nothing to do with packaging at all. Yes. > FWIW, Solfege as packaged for Guix works better on my system than the > Fedora package (which crashes with an SVG error on startup)... It=E2=80=99s interesting that we find it surprising. ;-) > From dc602efed43f839c964d976f30e73175e79a5f9f Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Tue, 31 Mar 2015 22:28:08 +0200 > Subject: [PATCH 1/2] gnu: Add Csound. > > * gnu/packages/audio.scm (csound): New variable. OK. > From d819aa3f733ed2d38e083c5cee0e96e3818a0612 Mon Sep 17 00:00:00 2001 > From: Ricardo Wurmus > Date: Wed, 11 Mar 2015 09:02:34 +0100 > Subject: [PATCH 2/2] gnu: Add Solfege. > > * gnu/packages/music.scm (solfege): New variable. [...] > + (alist-cons-before > + 'build 'fix-gettext > + (lambda _ > + ;; solfege/dataparser.py is in ISO-8859 encoding > + (with-fluids ((%default-port-encoding #f)) > + (substitute* "solfege/dataparser.py" > + (("_ =3D i18n") "# _ =3D i18n")))) Perhaps rename the phase to =E2=80=98disable-i18n=E2=80=99 for now, because= that=E2=80=99s really what it does AIUI. OK to push with these changes! Ludo=E2=80=99.