Re: [PATCH] Add Csound and Solfege.

[ludo@gnu.org (Ludovic Courtès)]

Ricardo Wurmus <rekado@elephly.net> skribis:

> patch-python-shebangs
> :  Self-explanatory.  As at least one file is in ISO-8859 encoding this
>    whole thing is wrapped in (with-fluids ((%default-port-encoding #f))
>    ...)

Why doesn’t the ‘patch-shebangs’ phase do its job?  Could
‘patch-shebang’ be used instead of ‘substitute*’?

> add-sitedirs
> :  This is something I think will be required for many pygtk-based
>    applications.  As *.pth files are not automatically considered,
>    dependencies of pygtk are not loaded and thus not found unless the
>    directories containing the *.pth files are added as sites.  I think
>    it would be better if we could find a way around patching each and
>    every PyGTK application in this ad-hoc manner.

Yeah.

> adjust-config-file-prefix
> :  Config files are usually loaded from /etc or /usr/share.  This
>    phase sets the prefix to the package output directory.

OK.  I suppose Solfege also supports reading per-user config files from
~/.config or similar?

> fix-gettext
> :  I have no idea what's wrong with the i18n of Solfege.  Upon
>    application start I'm greeted with locale errors and this particular
>    line looks like just wrong.  "i18n" is None at this point and the
>    application just crashes unless I comment the line.  I feel least
>    comfortable with this hack and I'd be glad if someone could find a
>    fix that makes this phase obsolete.

I don’t know what the Python API looks like.  The gettext manual
mentions an API with the ‘gettext.’ prefix, dunno if that’s a different
thing.

> Despite all these hacks and fixes, Solfege exhibits somewhat odd
> behaviour.  Sometimes an empty window pops up, accompanied by a timer
> error message on the command line:
>
>    /gnu/store/...-solfege-3.22.2/share/solfege/solfege/gu.py:334: Warning: Source ID 3071 was not found when attempting to remove it
>   gobject.source_remove(self.__timeout)
>
> I suspect some of these issues should be reported upstream because it
> seems that they have nothing to do with packaging at all.

Yes.

> FWIW, Solfege as packaged for Guix works better on my system than the
> Fedora package (which crashes with an SVG error on startup)...

It’s interesting that we find it surprising.  ;-)

> From dc602efed43f839c964d976f30e73175e79a5f9f Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Tue, 31 Mar 2015 22:28:08 +0200
> Subject: [PATCH 1/2] gnu: Add Csound.
>
> * gnu/packages/audio.scm (csound): New variable.

OK.

> From d819aa3f733ed2d38e083c5cee0e96e3818a0612 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Wed, 11 Mar 2015 09:02:34 +0100
> Subject: [PATCH 2/2] gnu: Add Solfege.
>
> * gnu/packages/music.scm (solfege): New variable.

[...]

> +           (alist-cons-before
> +            'build 'fix-gettext
> +            (lambda _
> +              ;; solfege/dataparser.py is in ISO-8859 encoding
> +              (with-fluids ((%default-port-encoding #f))
> +                (substitute* "solfege/dataparser.py"
> +                  (("_ = i18n") "# _ = i18n"))))

Perhaps rename the phase to ‘disable-i18n’ for now, because that’s
really what it does AIUI.

OK to push with these changes!

Ludo’.