From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?B?5a6L5paH5q2m?= <iyzsong@gmail.com>
Subject: Re: [PATCH 1/7] gnu: gobject-introspection: Update to 1.44.0.
Date: Wed, 22 Apr 2015 10:03:36 +0800
Message-ID: <87fv7sc41z.fsf@gmail.com>
References: <1429524721-21449-1-git-send-email-iyzsong@gmail.com>
	<87a8y119dj.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47749)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1Ykk0R-0006Rm-Q5
	for guix-devel@gnu.org; Tue, 21 Apr 2015 22:03:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <iyzsong@gmail.com>) id 1Ykk0P-0005bl-V2
	for guix-devel@gnu.org; Tue, 21 Apr 2015 22:03:15 -0400
In-Reply-To: <87a8y119dj.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

Ludovic Court=C3=A8s <ludo@gnu.org> writes:

> Hi!
>
> Note: this series should go to a =E2=80=98glib=E2=80=99 branch, which we=
=E2=80=99ll get Hydra to
> build.
>
> =E5=AE=8B=E6=96=87=E6=AD=A6 <iyzsong@gmail.com> skribis:
>
>> * gnu/packages/glib.scm (gobject-introspection): Update to 1.44.0.
>>   [source]: Use mirror://gnome.
>>   [arguments]<#:phases>: Remove.
>> * gnu/packages/patches/gobject-introspection-cc.patch: Rewrite to
>>   set os.environ['CC'] in 'giscanner/__init__.py'.
>
> I don=E2=80=99t know exactly what happened but something broke since the
> original patch went in.  The intent was described at
> <https://lists.gnu.org/archive/html/guix-devel/2013-11/msg00127.html>.
>
>> +Use gcc as the default C compiler if CC is not set.
>> +
>> +
>> +--- gobject-introspection-1.44.0.orig/giscanner/__init__.py	2014-08-04 =
22:37:07.000000000 +0800
>> ++++ gobject-introspection-1.44.0/giscanner/__init__.py	2015-04-20 17:30=
:26.507697234 +0800
>> +@@ -22,3 +22,5 @@
>> + builddir =3D os.environ.get('UNINSTALLED_INTROSPECTION_BUILDDIR')
>> + if builddir is not None:
>> +     __path__.append(os.path.join(builddir, 'giscanner'))
>> ++if not 'CC' in os.environ:
>> ++    os.environ['CC'] =3D 'gcc'
>
> Is it OK if $CC is set for all the child processes of giscanner?
IIUC, this didn't set $CC for child processes, just update the
os.environ dict (not the env table in unix way) for the python process.
>
> Assuming there=E2=80=99s no issue in this area, that looks good to me.  A=
nd
> there=E2=80=99s a whole bunch of CC=3Dgcc that you can remove afterwards.=
  :-)
Yes.
>
> Thanks!
>
> Ludo=E2=80=99.