From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] emacs: Enable 'guix-build-log-minor-mode' in shell buffers. Date: Sun, 01 Nov 2015 18:46:59 +0100 Message-ID: <87fv0p394c.fsf@gnu.org> References: <877fm5za7d.fsf@gmail.com> <87oafge1ui.fsf@gnu.org> <871tcalqgg.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zswif-0000h0-Ll for guix-devel@gnu.org; Sun, 01 Nov 2015 12:47:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zswic-0002Em-G4 for guix-devel@gnu.org; Sun, 01 Nov 2015 12:47:05 -0500 In-Reply-To: <871tcalqgg.fsf_-_@gmail.com> (Alex Kost's message of "Sat, 31 Oct 2015 23:42:55 +0300") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Alex Kost Cc: guix-devel@gnu.org Alex Kost skribis: > Not sure if it's really worth, but this can be done the same way as with > enabling 'guix-devel-mode' (as in the attached patch). So it can be > disabled by: > > (setq guix-build-log-minor-mode-activate nil) OK. > But then why don't we enable 'guix-prettify-mode' by default? As for > me, I don't think all these features should be automatically enabled, > dunno what is considered to be a good default: "full-featured" or "as > simple as possible". I=E2=80=99m mostly in favor of full-featured. The Emacs tradition is/was to provide something that had to be explicitly configured to get the features: in the old days, font-locking was disabled by default, and Gnus would do absolutely nothing until you had spent a couple of days configuring it. However, given the wealth of features now provided by guix.el, I think it=E2=80=99s best to enable most of them by default, at least those that ar= e not controversial. Otherwise, the risk is that people just won=E2=80=99t know = about them. =E2=80=98guix-build-log-minor-mode=E2=80=99 is clearly one of the things to= enable by default IMO. The situation is less clear for =E2=80=98guix-prettify-mode= =E2=80=99 because it changes the behavior of Emacs in a way that could be surprising to a newcomer. WDYT? > From 3991193fcc6700b1e198d5befcb6b1c651839ae0 Mon Sep 17 00:00:00 2001 > From: Alex Kost > Date: Sat, 31 Oct 2015 22:01:45 +0300 > Subject: [PATCH] emacs: Enable 'guix-build-log-minor-mode' in shell buffe= rs. > > * emacs/guix-build-log.el (guix-build-log-minor-mode-activate): New varia= ble. > (guix-build-log-minor-mode-activate-maybe): New function. > * emacs/guix-init.el: Add it to 'shell-mode-hook'. > * doc/emacs.texi (Emacs Build Log): Mention it. OK! Ludo=E2=80=99.