Re: [PATCH] emacs: Enable 'guix-build-log-minor-mode' in shell buffers.

[ludo@gnu.org (Ludovic Courtès)]

Alex Kost <alezost@gmail.com> skribis:

> Not sure if it's really worth, but this can be done the same way as with
> enabling 'guix-devel-mode' (as in the attached patch).  So it can be
> disabled by:
>
>   (setq guix-build-log-minor-mode-activate nil)

OK.

> But then why don't we enable 'guix-prettify-mode' by default?  As for
> me, I don't think all these features should be automatically enabled,
> dunno what is considered to be a good default: "full-featured" or "as
> simple as possible".

I’m mostly in favor of full-featured.  The Emacs tradition is/was to
provide something that had to be explicitly configured to get the
features: in the old days, font-locking was disabled by default, and
Gnus would do absolutely nothing until you had spent a couple of days
configuring it.

However, given the wealth of features now provided by guix.el, I think
it’s best to enable most of them by default, at least those that are not
controversial.  Otherwise, the risk is that people just won’t know about
them.

‘guix-build-log-minor-mode’ is clearly one of the things to enable by
default IMO.  The situation is less clear for ‘guix-prettify-mode’
because it changes the behavior of Emacs in a way that could be
surprising to a newcomer.

WDYT?

> From 3991193fcc6700b1e198d5befcb6b1c651839ae0 Mon Sep 17 00:00:00 2001
> From: Alex Kost <alezost@gmail.com>
> Date: Sat, 31 Oct 2015 22:01:45 +0300
> Subject: [PATCH] emacs: Enable 'guix-build-log-minor-mode' in shell buffers.
>
> * emacs/guix-build-log.el (guix-build-log-minor-mode-activate): New variable.
>   (guix-build-log-minor-mode-activate-maybe): New function.
> * emacs/guix-init.el: Add it to 'shell-mode-hook'.
> * doc/emacs.texi (Emacs Build Log): Mention it.

OK!

Ludo’.