[PATCH] segfaulting gnunet-gtk.

[PATCH] segfaulting gnunet-gtk.

[Ricardo Wurmus]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

Hi,

the attached patches make for a buildable gnunet-gtk package, but it
doesn’t seem fully functional.  I see a segfault when switching tabs
in “gnunet-setup” after first interacting with the URL dropdown.

In “gnunet-gtk” I also don’t see anything more than the images.  There
should be more, I’m sure.

Maybe someone with some more familiarity with GNUnet could take a look
at this and come up with a fix.

~~ Ricardo


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-gnunet-Add-gstreamer-and-plugins-to-inputs.patch --]
[-- Type: text/x-patch, Size: 831 bytes --]

From 5d277184ce57b792a5de13d5a607ca68159694f5 Mon Sep 17 00:00:00 2001
From: Ricardo Wurmus <rekado@elephly.net>
Date: Sun, 17 Jan 2016 15:28:53 +0100
Subject: [PATCH 1/2] gnu: gnunet: Add gstreamer and plugins to inputs.

* gnu/packages/gnunet.scm (gnunet)[inputs]: Add "gstreamer" and
  "gst-plugins-base".
---
 gnu/packages/gnunet.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index 11e5aa8..0b55c1a 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -208,6 +208,8 @@ supports HTTPS, HTTPS and GnuTLS.")
    (inputs
     `(("glpk" ,glpk)
       ("gnurl" ,gnurl)
+      ("gstreamer" ,gstreamer)
+      ("gst-plugins-base" ,gst-plugins-base)
       ("gnutls" ,gnutls)
       ("libextractor" ,libextractor)
       ("libgcrypt" ,libgcrypt)
-- 
2.6.3


[-- Attachment #3: 0002-gnu-Add-gnunet-gtk.patch --]
[-- Type: text/x-patch, Size: 2653 bytes --]

From 29708ddfff95b06ae2e7076d1e2fd13d93b782b9 Mon Sep 17 00:00:00 2001
From: Ni* Gillmann <ng@niasterisk.space>
Date: Wed, 13 Jan 2016 18:36:31 +0100
Subject: [PATCH 2/2] gnu: Add gnunet-gtk.

* gnu/packages/gnunet.scm (gnunet-gtk): New variable.

Co-authored-by: Ricardo Wurmus <rekado@elephly.net>
---
 gnu/packages/gnunet.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/gnunet.scm b/gnu/packages/gnunet.scm
index 0b55c1a..e06fe90 100644
--- a/gnu/packages/gnunet.scm
+++ b/gnu/packages/gnunet.scm
@@ -3,6 +3,8 @@
 ;;; Copyright © 2014 Sree Harsha Totakura <sreeharsha@totakura.in>
 ;;; Copyright © 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2016 Ni* Gillmann <ng@niasterisk.space>
+;;; Copyright © 2016 Ricardo Wurmus <rekado@elephly.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -22,14 +24,17 @@
 (define-module (gnu packages gnunet)
   #:use-module (gnu packages)
   #:use-module (gnu packages file)
+  #:use-module (gnu packages aidc)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages geeqie)
   #:use-module (gnu packages gettext)
   #:use-module (gnu packages glib)
+  #:use-module (gnu packages gnome)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages groff)
+  #:use-module (gnu packages gtk)
   #:use-module (gnu packages guile)
   #:use-module (gnu packages gstreamer)
   #:use-module (gnu packages libidn)
@@ -288,3 +293,30 @@ GNUnet services, including the @dfn{identity} and @dfn{file sharing}
 services.")
       (home-page "http://gnu.org/software/guix")
       (license license:gpl3+))))
+
+(define-public gnunet-gtk
+  (package (inherit gnunet)
+    (name "gnunet-gtk")
+    (version (package-version gnunet))
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnu/gnunet/gnunet-gtk-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1p38k1s6a2fmcfc9a7cf1zrdycm9h06kqdyand4s3k500nj6mb4g"))))
+    (arguments
+     `(#:configure-flags
+       (list "--without-libunique"
+             "--with-qrencode")))
+    (inputs
+     `(("gnunet" ,gnunet)
+       ("libgcrypt" ,libgcrypt)
+       ("gtk+" ,gtk+)
+       ("libextractor" ,libextractor)
+       ("glade3" ,glade3)
+       ("qrencode" ,qrencode)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("libglade" ,libglade)))
+    (synopsis "Graphical front-end tools for GNUnet")))
-- 
2.6.3

Re: [PATCH] segfaulting gnunet-gtk.

[Ludovic Courtès]

Ricardo Wurmus <rekado@elephly.net> skribis:

> the attached patches make for a buildable gnunet-gtk package, but it
> doesn’t seem fully functional.  I see a segfault when switching tabs
> in “gnunet-setup” after first interacting with the URL dropdown.
>
> In “gnunet-gtk” I also don’t see anything more than the images.  There
> should be more, I’m sure.
>
> Maybe someone with some more familiarity with GNUnet could take a look
> at this and come up with a fix.

You took it to the GNUnet hackers, hopefully they’ll come up with a
solution.

> From 5d277184ce57b792a5de13d5a607ca68159694f5 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sun, 17 Jan 2016 15:28:53 +0100
> Subject: [PATCH 1/2] gnu: gnunet: Add gstreamer and plugins to inputs.
>
> * gnu/packages/gnunet.scm (gnunet)[inputs]: Add "gstreamer" and
>   "gst-plugins-base".

OK.

Eventually we should probably have separate outputs or something, so we
can have core GNUnet with a minimal set of dependencies.

> From 29708ddfff95b06ae2e7076d1e2fd13d93b782b9 Mon Sep 17 00:00:00 2001
> From: Ni* Gillmann <ng@niasterisk.space>
> Date: Wed, 13 Jan 2016 18:36:31 +0100
> Subject: [PATCH 2/2] gnu: Add gnunet-gtk.
>
> * gnu/packages/gnunet.scm (gnunet-gtk): New variable.
>
> Co-authored-by: Ricardo Wurmus <rekado@elephly.net>

[...]

> +(define-public gnunet-gtk
> +  (package (inherit gnunet)

Could you add a comment about the bug with a link to the
gnunet-developers thread?

Otherwise LGTM, thanks!

Ludo’.

Re: [PATCH] segfaulting gnunet-gtk.

[Ricardo Wurmus]

Ludovic Courtès <ludo@gnu.org> writes:

>> From 29708ddfff95b06ae2e7076d1e2fd13d93b782b9 Mon Sep 17 00:00:00 2001
>> From: Ni* Gillmann <ng@niasterisk.space>
>> Date: Wed, 13 Jan 2016 18:36:31 +0100
>> Subject: [PATCH 2/2] gnu: Add gnunet-gtk.
>>
>> * gnu/packages/gnunet.scm (gnunet-gtk): New variable.
>>
>> Co-authored-by: Ricardo Wurmus <rekado@elephly.net>
>
> [...]
>
>> +(define-public gnunet-gtk
>> +  (package (inherit gnunet)
>
> Could you add a comment about the bug with a link to the
> gnunet-developers thread?

I added a comment with a link to the email in the list archive.
Thanks for the review!

~~ Ricardo