Re: [PATCH] gnu: Add gtk-vnc.

[iyzsong@member.fsf.org (宋文武)]

[-- Attachment #1: Type: text/plain, Size: 369 bytes --]

rennes@openmailbox.org writes:

> Hi again,
>
> i attach the patch for your revision.
Hi, this patch doesn't apply cleanly.
I made follow adjustments with it:

- Move it to gnome.scm, it's a gnome project after all :-)
- Enable SASL support.
- Remove "--enable-vala", it's auto-detected.
- Replace gjs with gobject-introspection, I don't see any use of
  gjs from it.


[-- Attachment #2: 0001-gnu-Add-gtk-vnc.patch --]
[-- Type: text/x-patch, Size: 2552 bytes --]

From db436ed87cb94b82c230962b5e454b8a440475ee Mon Sep 17 00:00:00 2001
From: Rene Saavedra <rennes@openmailbox.org>
Date: Wed, 27 Jan 2016 20:07:12 +0100
Subject: [PATCH] gnu: Add gtk-vnc.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* gnu/packages/gnome.scm (gtk-vnc): New variable.

Co-authored-by: 宋文武 <iyzsong@gmail.com>
---
 gnu/packages/gnome.scm | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 9ce750d..7656f38 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -45,6 +45,7 @@
   #:use-module (gnu packages check)
   #:use-module (gnu packages cups)
   #:use-module (gnu packages curl)
+  #:use-module (gnu packages cyrus-sasl)
   #:use-module (gnu packages databases)
   #:use-module (gnu packages djvu)
   #:use-module (gnu packages dns)
@@ -4567,3 +4568,40 @@ properties, screen resolution, and other GNOME parameters.")
      "GNOME Shell provides core user interface functions for the GNOME desktop,
 like switching to windows and launching applications.")
     (license license:gpl2+)))
+
+(define-public gtk-vnc
+  (package
+    (name "gtk-vnc")
+    (version "0.5.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://gnome/sources/" name "/"
+                           (version-major+minor version) "/"
+                           name "-" version ".tar.xz"))
+       (sha256
+        (base32
+         "1rwwdh7lb16xdmy76ca6mpqfc3zfl3a4bkcr0qb6hs6ffrxak2j8"))))
+    (build-system gnu-build-system)
+    (arguments
+     '(#:configure-flags '("--with-gtk=3.0")))
+    (propagated-inputs
+     `(("gtk+" ,gtk+))) ; required by gtk-vnc-2.0.pc.
+    (inputs
+     `(("cyrus-sasl" ,cyrus-sasl)
+       ("gnutls" ,gnutls)
+       ("libgcrypt" ,libgcrypt)
+       ("pulseaudio" ,pulseaudio)))
+    (native-inputs
+     `(("glib:bin" ,glib "bin")
+       ("gobject-introspection" ,gobject-introspection)
+       ("intltool" ,intltool)
+       ("pkg-config" ,pkg-config)
+       ("vala" ,vala)))
+    (home-page "https://wiki.gnome.org/Projects/gtk-vnc")
+    (synopsis "VNC viewer widget for GTK+")
+    (description
+     "GTK-VNC is an API used by Vinagre client application,
+Boxes and virt-viewer.  GTK-VNC supports authentication extensions
+as SASL, TLS, VeNCrypt.  Additionally supports encoding extensions.")
+    (license license:lgpl2.1+)))
-- 
2.5.0


[-- Attachment #3: Type: text/plain, Size: 259 bytes --]


And the description still needs more love. I think saying it's "an API"
for some applications doesn't show much about what it does. Maybe
"remote desktop" should be mentioned.

Well, I'm surely not the right person to review descriptions, just my
two coins.