Re: [PATCH] Add MilkyTracker to Guix

[Nils Gillmann <niasterisk@grrlz.net>]

kei@openmailbox.org writes:

> The attached is a patch to gnu/packages/music.scm that allows a
> minimal and functional build of MilkyTracker. I'm unsure if this is
> formatted correctly, but I'm willing to learn. :-)

Thanks!

For Guix we follow the GNU coding standard for patches, which
also include formated commit messages.
https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html

This also requires adding a name + email to the header, a legal
name is not necessarily required, it can also be a pseudonym or a
known name you have.

> --- music.scm.bak	2016-03-25 17:39:35.959715114 -0400
> +++ music.scm	2016-03-25 19:39:44.754396091 -0400
> @@ -78,6 +78,7 @@
>    #:use-module (gnu packages rdf)
>    #:use-module (gnu packages readline)
>    #:use-module (gnu packages rsync)
> +  #:use-module (gnu packages sdl)
>    #:use-module (gnu packages tcl)
>    #:use-module (gnu packages texinfo)
>    #:use-module (gnu packages texlive)
> @@ -1305,3 +1306,26 @@
>  of tools for manipulating and accessing your music.")
>      (license license:expat)))
>  
> +(define-public milkytracker
> +  (package
> +    (name "milkytracker")
> +    (version "0.90.86")
> +    (source (origin
> +	      (method url-fetch)
> +	      (uri
> +	       (string-append "http://milkytracker.org/files/milkytracker-"
> +				  version
> +				  ".tar.gz"))

not necessarily wrong, but as you defined a name:
(string-append "http://milkytracker.org/files/"
               name "-" version ".tar.gz")

> +              (sha256
> +               (base32
> +                "0mqjkhvjyp5hnzm1ln3b2qjclviayxylcyml96pjdxgbaqcqa2zz"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     '(#:configure-flags `("--without-alsa" "--without-jack")))
> +    (inputs
> +     `(("sdl" ,sdl)
> +       ("zlib" ,zlib)))
> +    (synopsis "MilkyTracker is a free software multi-platform  music tracker for composing music in the MOD and XM module file formats.")

I guess you don't use emacs? We have rules defined for line
length etc, I don't know the exact length at the moment,
something around 68 or 70 if I am right.

> +    (description "MilkyTracker is a free software, multi-platform music application for creating .MOD and .XM module files. It attempts to recreate the module replay and user experience of the popular DOS program Fasttracker II, with special playback modes available for improved Amiga ProTracker 2/3 compatibility.")

same.

> +    (home-page "http://milkytracker.org/")
> +    (license license:gpl3)))

I did not testrun it, but that's the stylistic part I can comment
on right now.

-- 
ng
personal contact: http://krosos.sdf.org
EDN: https://wiki.c3d2.de/EDN