From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Gradl Subject: Re: [PATCH] Add libiax Date: Mon, 30 May 2016 14:47:55 -0500 Message-ID: <87fuszwcno.fsf@openmailbox.org> References: <87shx17pbq.fsf@openmailbox.org> <20160529004847.GA9375@jasmine> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7TAX-0006B8-6F for guix-devel@gnu.org; Mon, 30 May 2016 15:48:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7TAS-0000mu-0Z for guix-devel@gnu.org; Mon, 30 May 2016 15:48:08 -0400 Received: from mail2.openmailbox.org ([62.4.1.33]:45793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7TAR-0000ly-Mo for guix-devel@gnu.org; Mon, 30 May 2016 15:48:03 -0400 In-Reply-To: <20160529004847.GA9375@jasmine> (Leo Famulari's message of "Sat, 28 May 2016 20:48:47 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Thank you for your review! Leo Famulari writes: > On Sat, May 28, 2016 at 06:08:57PM -0500, Lukas Gradl wrote: >> >> Hi Guix, >> >> Attached is a patch for LibIAX, a library that is used by the Ring >> (formerly SFLphone). > > Cool! > >> Upstream seems to use no version numbers. I used the git commit ID that >> is also refered to in the version that is bundeled with Ring. This is >> also the latest commit to libiax. > > Since there are no upstream versions, I think the version string should > use 0.0.0 to refer to the upstream version, then the Guix package > revision number, and then the 7 characters of the commit. > > So, it would end up like this: 0.0.0-1.cabba9e > > See here: > https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html#Version-Numbers OK, Thank you for pointing this out! I missed that in the manual. I updated the patch accordingly and will send it soon. > >> + (package >> + (name "libiax") >> + (version (string-append "2-" (string-take commit 7))) > > By the way, what does the "2-" refer to? Upstream seems to refer to the software as "iax" "libiax" and "libiax2" interchangeably. The "2" was the closest thing I could find to a version number. Thank you!