From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Subject: Re: [PATCH] gnu: Add nethack. Date: Wed, 08 Jun 2016 14:59:35 +0200 Message-ID: <87fusnj0p4.fsf@gnu.org> References: <20160531175630.0bfd76ff@openmailbox.org> <87y46kwt82.fsf@gnu.org> <20160606162541.5254ed6c@openmailbox.org> <20160607172028.GA19231@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAd5D-0001VD-TE for guix-devel@gnu.org; Wed, 08 Jun 2016 08:59:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAd58-0006jr-TP for guix-devel@gnu.org; Wed, 08 Jun 2016 08:59:42 -0400 In-Reply-To: <20160607172028.GA19231@jasmine> (Leo Famulari's message of "Tue, 7 Jun 2016 13:20:28 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org Leo Famulari skribis: > On Mon, Jun 06, 2016 at 04:25:41PM -0400, Kei Kebreau wrote: >> ludo@gnu.org (Ludovic Court=C3=A8s) wrote: >> > > + (add-after 'move-state-files 'wrap-program >> >=20 >> > Do we really need this wrapper? Can=E2=80=99t we instead take it as a= patch >> > from Debian or something? I=E2=80=99m not a fan of inline Bash code, = and not >> > very confident of scripts that do =E2=80=98rm -rf=E2=80=99. :-) >> >=20 >> Unfortunately, Debian doesn't have any related patches because it's >> state files are writable in the equivalent of our store directories. It >> seems like the bash script will have to stay for the sake of >> functionality unless someone comes up with something cleaner, though I >> prefer to avoid them. Long ago, I lost a GNU/Linux installation to >> "rm -rf"... > > If Nethack lacks the ability to configure the location of the state > files, there is still a string (or several) in the source code that > looks like '/usr/share/nethack'. I think we should change this string to > something more appropriate instead of wrapping Nethack. Yeah, I would also prefer something along these lines. What do you think, Kei? Does that sound doable? Thanks, Ludo=E2=80=99.