From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add fontconfig-path-max.
Date: Tue, 05 Jul 2016 10:51:23 +0200
Message-ID: <87furozcvo.fsf@gnu.org>
References: <7b313a7566d04932f94fb33e7a63c222@openmailbox.org>
	<877fd1hkzn.fsf@gnu.org>
	<811ca2f8679999e2777cb5e559e69c37@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46220)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bKM5O-0004qP-Pe
	for guix-devel@gnu.org; Tue, 05 Jul 2016 04:52:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bKM5K-0007QU-L8
	for guix-devel@gnu.org; Tue, 05 Jul 2016 04:52:06 -0400
In-Reply-To: <811ca2f8679999e2777cb5e559e69c37@openmailbox.org>
	(rennes@openmailbox.org's message of "Mon, 04 Jul 2016 20:26:33
	-0500")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: rennes@openmailbox.org
Cc: guix-devel@gnu.org

Hi,

rennes@openmailbox.org skribis:

> The code has changed in the current version, I used the version 2.12.0
> of the package to update the patch.
>
> how i know if the program will crash at run time?.

You could build it on GNU/Linux, using:

  ./pre-inst-env guix build fontconfig -K

Hopefully Fontconfig=E2=80=99s test suite would trigger the crash, but manu=
al
testing might be needed too.

> From 21f812c2f496bdb7c39e297f66e09ea35968ddfb Mon Sep 17 00:00:00 2001
> From: Rene Saavedra <rennes@openmailbox.org>
> Date: Mon, 4 Jul 2016 19:34:48 -0500
> Subject: [PATCH] gnu: Add fontconfig.

Please see
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>
regarding commit logs.  :-)


[...]

> +--- a/src/fcstat.c
> ++++ b/src/fcstat.c
> +@@ -278,7 +278,8 @@ FcDirChecksum (const FcChar8 *dir, time_t *checksum)
> + 	{
> + #endif
> + 	struct stat statb;
> +-	char f[PATH_MAX + 1];
> ++	int size =3D 128;
> ++	char *f =3D malloc (size);

This is not OK, in part because it introduces a memory leak.  The fix
should be along the same lines as the rest of the patch.

Could you check whether Debian has a patch for a more recent version of
Fontconfig?

Thanks,
Ludo=E2=80=99.