Re: [PATCH] gnu: Add mono.

[Jan Nieuwenhuizen <janneke@gnu.org>]

[-- Attachment #1: Type: text/plain, Size: 3642 bytes --]

Leo Famulari writes:

> On Fri, Jul 15, 2016 at 09:32:43PM +0200, Jan Nieuwenhuizen wrote:
>> Subject: [PATCH] gnu: Add mono.
>> 
>> * gnu/packages/mono.scm: New file.
>> * gnu/packages/local.mk (GNU_SYSTEM_MODULES): Add it.
>
> Thank you!
>
> I assume this mono is working for you? I'm wondering if the problems
> requiring skipped tests hide a larger problem or if it's benign.

It is working for me.  I am using for a quite narrow range of
non-graphical applications running formally verified code.  So on the
one hand I know that it's running and correct, on the other hand I'm
probably running/testing only a small fraction of mono.

> Do you know if mono is supposed to work on all of our architectures? Or,
> should we disable it on some of them?

I don't really know, but given that it's a re-implementation of Java, I
can only assume it's also write once, debug everywhere.

>> +              (snippet
>
> Did you try doing these substitutions in a build phase? The origin
> snippet affects what you get from `guix build --source mono`, so we tend
> to reserve it for removing non-free components, so that we don't
> distribute things that we don't have a right to distribute.

I didn't know, thanks.  I have moved these to the build phase.

>> +                  ;; tests fail, trying to access $HOME
>> +                  (substitute* "mcs/class/Makefile"
>> +                    (("^include ../build/rules.make" all)
>> +                     (string-append
>> +                      all
>> +                      "\nrun-test-recursive:\n\t@echo skipping tests\n")))
>
> After moving this into a build phase, there could be a prior phase
> 'set-env' that just sets $HOME to '/tmp'. Can you check if that works?

I added that phase and removed this toplevel disabling of
mcs/class/Makefile and went up to adding individual thee failing tests
like so

             (substitute*
              '("mcs/tools/sqlmetal/Makefile"
                "mcs/class/Microsoft.Build.Tasks/Makefile"
                "mcs/class/Microsoft.Build/Makefile"
                "mcs/class/corlib/Makefile"
                "mcs/class/System/Makefile"
                "mcs/class/System.XML/Makefile"
                "mcs/class/System.Configuration/Makefile"
                "mcs/class/System.IO.Compression/Makefile"
                "mcs/class/System.IO.Compression.FileSystem/Makefile"
                "mcs/class/System.Drawing/Makefile")
               (("^include ../../build/rules.make" all)
                (string-append
                 "NO_TEST:=true\n"
                 all
                 "\nrun-test-lib:\n\t@echo skipping test\n")))
               
and then gave up, and reverted to disabling all mcs/class tests again.

>> +    (build-system gnu-build-system)
>> +    (native-inputs
>> +     `(("gettext" ,gnu-gettext)
>> +       ("glib" ,glib)
>
> I notice many uses of glib:bin rather than the full glib output. But,
> to be honest, I don't understand the distinction ;)

glib:bin only holds the executables sometimes needed during build.  Mono
uses the glib shared library, so bin won't do.

>> +     ;; these 3 tests fail
>> +     `(#:make-flags
>> +       `(,(string-append "PLATFORM_DISABLED_TESTS="
>> +                         " appdomain-unload.exe"
>> +                         " delegate2.exe"
>> +                         " finally_guard.exe"
>> +                         " remoting4.exe"))
>
> 4 tests?

Thanks, 4.

>
>> +       #:parallel-tests? #f))
>
> Parallel testing is not supported? Let's add a comment.

Done.

>> +    (home-page "http://mono-project.org/")
>
> s/org/com/

Done.

Find a new patch attached.

Greetings,
Jan


[-- Attachment #2: 0001-gnu-Add-mono.patch --]
[-- Type: text/x-patch, Size: 5932 bytes --]

From 2aca1448350238fa795be65b71eeb59ffff2fea8 Mon Sep 17 00:00:00 2001
From: Jan Nieuwenhuizen <janneke@gnu.org>
Date: Wed, 13 Jul 2016 14:47:55 +0200
Subject: [PATCH] gnu: Add mono.

* gnu/packages/mono.scm: New file.
* gnu/packages/local.mk (GNU_SYSTEM_MODULES): Add it.
---
 gnu/local.mk          |   1 +
 gnu/packages/mono.scm | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 110 insertions(+)
 create mode 100644 gnu/packages/mono.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 3a0d5c2..dfc038f 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -236,6 +236,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/mg.scm				\
   %D%/packages/mit-krb5.scm			\
   %D%/packages/moe.scm				\
+  %D%/packages/mono.scm				\
   %D%/packages/moreutils.scm			\
   %D%/packages/mpd.scm				\
   %D%/packages/mp3.scm				\
diff --git a/gnu/packages/mono.scm b/gnu/packages/mono.scm
new file mode 100644
index 0000000..75e39af
--- /dev/null
+++ b/gnu/packages/mono.scm
@@ -0,0 +1,109 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2016 Jan Nieuwenhuizen <janneke@gnu.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages mono)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages glib)
+  #:use-module (gnu packages perl)
+  #:use-module (gnu packages python)
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix git-download)
+  #:use-module (guix build-system gnu))
+
+(define-public mono
+  (package
+    (name "mono")
+    (version "4.4.1.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "http://download.mono-project.com/sources/mono/"
+                    name "-" version
+                    ".tar.bz2"))
+              (sha256
+               (base32
+                "0jibyvyv2jy8dq5ij0j00iq3v74r0y90dcjc3dkspcfbnn37cphn"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     `(("gettext" ,gnu-gettext)
+       ("glib" ,glib)
+       ("libxslt" ,libxslt)
+       ("perl" ,perl)
+       ("python" ,python-2)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'set-env
+           (lambda _ ;;* (#:key inputs #:allow-other-keys)
+             ;; all tests under mcs/class fail trying to access $HOME
+             (setenv "HOME" "/tmp")))
+         (add-after 'unpack 'patch-tests
+           (lambda _  ;;* (#:key inputs #:allow-other-keys)
+             (substitute* "mono/tests/Makefile.in"
+               ;; does not build: no rule to make unhandled-exception-*
+               (("@test-unhandled-exception-2:" all)
+                (string-append all "#")))
+             (substitute* "mcs/tools/mono-symbolicate/Makefile"
+               ;; does not build: Source file `Test/StackTraceDumper.cs'
+               ;; could not be found
+               (("^check: test-local") "check:\ntest-local:")
+               (("^test-local: all") "disabled-test-local:"))
+             (substitute* "mono/unit-tests/Makefile.in"
+               ;; test fails
+               (("^test-sgen-qsort.log:")
+                "disabled-test-sgen-qsort.log:\ntest-sgen-qsort.log:"))
+             ;; tests fail, trying to access $HOME
+             (substitute* "mcs/class/Makefile"
+               (("^include ../build/rules.make" all)
+                (string-append
+                 all
+                 "\nrun-test-recursive:\n\t@echo skipping tests\n")))
+             ;; tests fail, trying to access $HOME
+             (substitute* "mcs/class/Microsoft.Build.Tasks/Makefile"
+               (("^include ../../build/rules.make" all)
+                (string-append
+                 all
+                 "\nrun-test-recursive:\n\t@echo skipping tests\n")))
+             (substitute* '("mcs/tools/mono-shlib-cop/Makefile"
+                            "mcs/tools/mdoc/Makefile")
+               (("^run-test-local:" all)
+                (string-append "#" all)))
+             (substitute* "mcs/tools/sqlmetal/Makefile"
+               (("^include ../../build/rules.make" all)
+                (string-append
+                 "NO_TEST:=true\n"
+                 all
+                 "\nrun-test-lib:\n\t@echo skipping test\n"))))))
+       ;; these 4 tests fail
+       #:make-flags `(,(string-append "PLATFORM_DISABLED_TESTS="
+                                      " appdomain-unload.exe"
+                                      " delegate2.exe"
+                                      " finally_guard.exe"
+                                      " remoting4.exe"))
+       ;; running tests in parallel fails
+       #:parallel-tests? #f))
+    (synopsis "Compiler and libraries for the C# programming language")
+    (description "Mono is a compiler, vm, debugger and set of libraries for
+C#, a C-style programming language from Microsoft that is very similar to
+Java.")
+    (home-page "http://mono-project.com/")
+    (license license:x11)))
-- 
2.8.4


[-- Attachment #3: Type: text/plain, Size: 156 bytes --]



-- 
Jan Nieuwenhuizen <janneke@gnu.org> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar®  http://AvatarAcademy.nl