flashrom package needs update

flashrom package needs update

[ng0]

Someone should update flashrom to 0.9.9. (https://www.flashrom.org/Flashrom/0.9.9)
I tried and do not understand enough of flashrom to update the patch we need.
-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org

Re: flashrom package needs update

[ng0]

ng0 <ng0@we.make.ritual.n0.is> writes:

> Someone should update flashrom to 0.9.9. (https://www.flashrom.org/Flashrom/0.9.9)
> I tried and do not understand enough of flashrom to update the patch we need.

Additionally we need to check what's different about GuixSD that this
happens:

root@shadowwalker /home/ng0# flashrom -p internal -w libreboot_latest_stable.rom
flashrom v0.9.7-r1711 on Linux 4.7.0-gnu (x86_64)
flashrom is free software, get the source code at http://www.flashrom.org

Calibrating delay loop... OK.
Error accessing high tables, 0x100000 bytes at 0x000000007dad6000
/dev/mem mmap failed: Operation not permitted
Failed getting access to coreboot high tables.
========================================================================
WARNING! You seem to be running flashrom on an unsupported laptop.
Laptops, notebooks and netbooks are difficult to support and we
recommend to use the vendor flashing utility. The embedded controller
(EC) in these machines often interacts badly with flashing.
See the manpage and http://www.flashrom.org/Laptops for details.

If flash is shared with the EC, erase is guaranteed to brick your laptop
and write may brick your laptop.
Read and probe may irritate your EC and cause fan failure, backlight
failure and sudden poweroff.
You have been warned.
========================================================================
Aborting.
Error: Programmer initialization failed.



I value that GuixSD seems to be more protective than any other system in
that regard where I could just become root and run flashrom, but maybe
we need to make an exception for flashrom and similar software.
Booting into ubuntu-live and running a statically linked binary of
flashrom just made me flash libreboot stable. I want to do this from
within GuixSD.
-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org

Re: flashrom package needs update

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 2373 bytes --]


ng0 <ng0@we.make.ritual.n0.is> writes:

> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> Someone should update flashrom to 0.9.9. (https://www.flashrom.org/Flashrom/0.9.9)
>> I tried and do not understand enough of flashrom to update the patch we need.
>
> Additionally we need to check what's different about GuixSD that this
> happens:
>
> root@shadowwalker /home/ng0# flashrom -p internal -w libreboot_latest_stable.rom
> flashrom v0.9.7-r1711 on Linux 4.7.0-gnu (x86_64)
> flashrom is free software, get the source code at http://www.flashrom.org
>
> Calibrating delay loop... OK.
> Error accessing high tables, 0x100000 bytes at 0x000000007dad6000
> /dev/mem mmap failed: Operation not permitted
> Failed getting access to coreboot high tables.
> ========================================================================
> WARNING! You seem to be running flashrom on an unsupported laptop.
> Laptops, notebooks and netbooks are difficult to support and we
> recommend to use the vendor flashing utility. The embedded controller
> (EC) in these machines often interacts badly with flashing.
> See the manpage and http://www.flashrom.org/Laptops for details.
>
> If flash is shared with the EC, erase is guaranteed to brick your laptop
> and write may brick your laptop.
> Read and probe may irritate your EC and cause fan failure, backlight
> failure and sudden poweroff.
> You have been warned.
> ========================================================================
> Aborting.
> Error: Programmer initialization failed.
>
>
>
> I value that GuixSD seems to be more protective than any other system in
> that regard where I could just become root and run flashrom, but maybe
> we need to make an exception for flashrom and similar software.
> Booting into ubuntu-live and running a statically linked binary of
> flashrom just made me flash libreboot stable. I want to do this from
> within GuixSD.

This is mentioned in Libreboot's documentation (top of the page here:
https://libreboot.org/docs/install/index.html). The GuixSD Linux-libre
kernel is configured with CONFIG_STRICT_DEVMEM enabled, which I presume
Libreboot uses for software-based flashing.

If you add linux to the list "use-package-modules" in your system
configuration and add (kernel-arguments '("iomem=relaxed")) to your
"operating-system" configuration, the flashing utility will work correctly.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: flashrom package needs update

[ng0]

Kei Kebreau <kei@openmailbox.org> writes:

> [ Unknown signature status ]
>
> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>
>>> Someone should update flashrom to 0.9.9. (https://www.flashrom.org/Flashrom/0.9.9)
>>> I tried and do not understand enough of flashrom to update the patch we need.
>>
>> Additionally we need to check what's different about GuixSD that this
>> happens:
>>
>> root@shadowwalker /home/ng0# flashrom -p internal -w libreboot_latest_stable.rom
>> flashrom v0.9.7-r1711 on Linux 4.7.0-gnu (x86_64)
>> flashrom is free software, get the source code at http://www.flashrom.org
>>
>> Calibrating delay loop... OK.
>> Error accessing high tables, 0x100000 bytes at 0x000000007dad6000
>> /dev/mem mmap failed: Operation not permitted
>> Failed getting access to coreboot high tables.
>> ========================================================================
>> WARNING! You seem to be running flashrom on an unsupported laptop.
>> Laptops, notebooks and netbooks are difficult to support and we
>> recommend to use the vendor flashing utility. The embedded controller
>> (EC) in these machines often interacts badly with flashing.
>> See the manpage and http://www.flashrom.org/Laptops for details.
>>
>> If flash is shared with the EC, erase is guaranteed to brick your laptop
>> and write may brick your laptop.
>> Read and probe may irritate your EC and cause fan failure, backlight
>> failure and sudden poweroff.
>> You have been warned.
>> ========================================================================
>> Aborting.
>> Error: Programmer initialization failed.
>>
>>
>>
>> I value that GuixSD seems to be more protective than any other system in
>> that regard where I could just become root and run flashrom, but maybe
>> we need to make an exception for flashrom and similar software.
>> Booting into ubuntu-live and running a statically linked binary of
>> flashrom just made me flash libreboot stable. I want to do this from
>> within GuixSD.
>
> This is mentioned in Libreboot's documentation (top of the page here:
> https://libreboot.org/docs/install/index.html). The GuixSD Linux-libre
> kernel is configured with CONFIG_STRICT_DEVMEM enabled, which I presume
> Libreboot uses for software-based flashing.
>
> If you add linux to the list "use-package-modules" in your system
> configuration and add (kernel-arguments '("iomem=relaxed")) to your
> "operating-system" configuration, the flashing utility will work correctly.

Oh, interesting. Thanks for the explanation. Do you think we should add
a pointer to this somewhere in the documentation, or add a link pointing
to this email thread?
I feel like this needs to be explained or be visible somewhere at our
side.

I think I want to keep this feature, and reconfigure the system only for
updating libre/coreboot.

Thanks
-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org

Re: flashrom package needs update

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 3300 bytes --]

ng0 <ng0@we.make.ritual.n0.is> writes:

> Kei Kebreau <kei@openmailbox.org> writes:
>
>> [ Unknown signature status ]
>>
>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>
>>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>>
>>>> Someone should update flashrom to 0.9.9. (https://www.flashrom.org/Flashrom/0.9.9)
>>>> I tried and do not understand enough of flashrom to update the patch we need.
>>>
>>> Additionally we need to check what's different about GuixSD that this
>>> happens:
>>>
>>> root@shadowwalker /home/ng0# flashrom -p internal -w libreboot_latest_stable.rom
>>> flashrom v0.9.7-r1711 on Linux 4.7.0-gnu (x86_64)
>>> flashrom is free software, get the source code at http://www.flashrom.org
>>>
>>> Calibrating delay loop... OK.
>>> Error accessing high tables, 0x100000 bytes at 0x000000007dad6000
>>> /dev/mem mmap failed: Operation not permitted
>>> Failed getting access to coreboot high tables.
>>> ========================================================================
>>> WARNING! You seem to be running flashrom on an unsupported laptop.
>>> Laptops, notebooks and netbooks are difficult to support and we
>>> recommend to use the vendor flashing utility. The embedded controller
>>> (EC) in these machines often interacts badly with flashing.
>>> See the manpage and http://www.flashrom.org/Laptops for details.
>>>
>>> If flash is shared with the EC, erase is guaranteed to brick your laptop
>>> and write may brick your laptop.
>>> Read and probe may irritate your EC and cause fan failure, backlight
>>> failure and sudden poweroff.
>>> You have been warned.
>>> ========================================================================
>>> Aborting.
>>> Error: Programmer initialization failed.
>>>
>>>
>>>
>>> I value that GuixSD seems to be more protective than any other system in
>>> that regard where I could just become root and run flashrom, but maybe
>>> we need to make an exception for flashrom and similar software.
>>> Booting into ubuntu-live and running a statically linked binary of
>>> flashrom just made me flash libreboot stable. I want to do this from
>>> within GuixSD.
>>
>> This is mentioned in Libreboot's documentation (top of the page here:
>> https://libreboot.org/docs/install/index.html). The GuixSD Linux-libre
>> kernel is configured with CONFIG_STRICT_DEVMEM enabled, which I presume
>> Libreboot uses for software-based flashing.
>>
>> If you add linux to the list "use-package-modules" in your system
>> configuration and add (kernel-arguments '("iomem=relaxed")) to your
>> "operating-system" configuration, the flashing utility will work correctly.
>
> Oh, interesting. Thanks for the explanation. Do you think we should add
> a pointer to this somewhere in the documentation, or add a link pointing
> to this email thread?
> I feel like this needs to be explained or be visible somewhere at our
> side.
>
I agree. It should probably be mentioned in the "System Configuration"
section of the manual. I would take me some time to write it up, as my
schedule is just starting to calm itself and I have no experience with
texinfo, so if someone else picked it up before me, I wouldn't complain.

> I think I want to keep this feature, and reconfigure the system only for
> updating libre/coreboot.
>
I agree here, too.

> Thanks
You're welcome! :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: flashrom package needs update

[ng0]

Okay, but the package still needs an update, is someone up to this?

The patch we apply needs to be adjusted.

Kei Kebreau <kei@openmailbox.org> writes:

> [ Unknown signature status ]
> ng0 <ng0@we.make.ritual.n0.is> writes:
>
>> Kei Kebreau <kei@openmailbox.org> writes:
>>
>>> [ Unknown signature status ]
>>>
>>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>>
>>>> ng0 <ng0@we.make.ritual.n0.is> writes:
>>>>
>>>>> Someone should update flashrom to 0.9.9. (https://www.flashrom.org/Flashrom/0.9.9)
>>>>> I tried and do not understand enough of flashrom to update the patch we need.
>>>>
>>>> Additionally we need to check what's different about GuixSD that this
>>>> happens:
>>>>
>>>> root@shadowwalker /home/ng0# flashrom -p internal -w libreboot_latest_stable.rom
>>>> flashrom v0.9.7-r1711 on Linux 4.7.0-gnu (x86_64)
>>>> flashrom is free software, get the source code at http://www.flashrom.org
>>>>
>>>> Calibrating delay loop... OK.
>>>> Error accessing high tables, 0x100000 bytes at 0x000000007dad6000
>>>> /dev/mem mmap failed: Operation not permitted
>>>> Failed getting access to coreboot high tables.
>>>> ========================================================================
>>>> WARNING! You seem to be running flashrom on an unsupported laptop.
>>>> Laptops, notebooks and netbooks are difficult to support and we
>>>> recommend to use the vendor flashing utility. The embedded controller
>>>> (EC) in these machines often interacts badly with flashing.
>>>> See the manpage and http://www.flashrom.org/Laptops for details.
>>>>
>>>> If flash is shared with the EC, erase is guaranteed to brick your laptop
>>>> and write may brick your laptop.
>>>> Read and probe may irritate your EC and cause fan failure, backlight
>>>> failure and sudden poweroff.
>>>> You have been warned.
>>>> ========================================================================
>>>> Aborting.
>>>> Error: Programmer initialization failed.
>>>>
>>>>
>>>>
>>>> I value that GuixSD seems to be more protective than any other system in
>>>> that regard where I could just become root and run flashrom, but maybe
>>>> we need to make an exception for flashrom and similar software.
>>>> Booting into ubuntu-live and running a statically linked binary of
>>>> flashrom just made me flash libreboot stable. I want to do this from
>>>> within GuixSD.
>>>
>>> This is mentioned in Libreboot's documentation (top of the page here:
>>> https://libreboot.org/docs/install/index.html). The GuixSD Linux-libre
>>> kernel is configured with CONFIG_STRICT_DEVMEM enabled, which I presume
>>> Libreboot uses for software-based flashing.
>>>
>>> If you add linux to the list "use-package-modules" in your system
>>> configuration and add (kernel-arguments '("iomem=relaxed")) to your
>>> "operating-system" configuration, the flashing utility will work correctly.
>>
>> Oh, interesting. Thanks for the explanation. Do you think we should add
>> a pointer to this somewhere in the documentation, or add a link pointing
>> to this email thread?
>> I feel like this needs to be explained or be visible somewhere at our
>> side.
>>
> I agree. It should probably be mentioned in the "System Configuration"
> section of the manual. I would take me some time to write it up, as my
> schedule is just starting to calm itself and I have no experience with
> texinfo, so if someone else picked it up before me, I wouldn't complain.
>
>> I think I want to keep this feature, and reconfigure the system only for
>> updating libre/coreboot.
>>
> I agree here, too.
>
>> Thanks
> You're welcome! :-)

-- 
ng0
For non-prism friendly talk find me on http://www.psyced.org

[PATCH] gnu: Update flashrom to 0.9.9

[Danny Milosavljevic]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]


gnu: Update flashrom to 0.9.9

* gnu/packages/flashing-tools.scm (flashrom): Changed.
* gnu/packages/patches/flashrom-use-libftdi1.patch: Removed.
* gnu/local.mk: Remove mention of "flashrom-use-libftdi1.patch".
---
 gnu/local.mk                                     |  1 -
 gnu/packages/flashing-tools.scm                  | 11 ++--
 gnu/packages/patches/flashrom-use-libftdi1.patch | 70 ------------------------
 3 files changed, 6 insertions(+), 76 deletions(-)
 delete mode 100644 gnu/packages/patches/flashrom-use-libftdi1.patch


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Update-flashrom-to-0.9.9.patch --]
[-- Type: text/x-patch; name="0001-gnu-Update-flashrom-to-0.9.9.patch", Size: 5388 bytes --]

diff --git a/gnu/local.mk b/gnu/local.mk
index 550897e..0308f67 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -511,7 +511,6 @@ dist_patch_DATA =						\
   %D%/packages/patches/fasthenry-spFactor.patch			\
   %D%/packages/patches/findutils-localstatedir.patch		\
   %D%/packages/patches/findutils-test-xargs.patch		\
-  %D%/packages/patches/flashrom-use-libftdi1.patch		\
   %D%/packages/patches/flint-ldconfig.patch			\
   %D%/packages/patches/fltk-shared-lib-defines.patch		\
   %D%/packages/patches/fltk-xfont-on-demand.patch		\
diff --git a/gnu/packages/flashing-tools.scm b/gnu/packages/flashing-tools.scm
index d0c164e..a55ed96 100644
--- a/gnu/packages/flashing-tools.scm
+++ b/gnu/packages/flashing-tools.scm
@@ -38,16 +38,15 @@
 (define-public flashrom
   (package
     (name "flashrom")
-    (version "0.9.7")
+    (version "0.9.9")
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "http://download.flashrom.org/releases/flashrom-"
+                    "https://download.flashrom.org/releases/flashrom-"
                     version ".tar.bz2"))
               (sha256
                (base32
-                "1s9pc4yls2s1gcg2ar4q75nym2z5v6lxq36bl6lq26br00nj2mas"))
-              (patches (search-patches "flashrom-use-libftdi1.patch"))))
+                "0i9wg1lyfg99bld7d00zqjm9f0lk6m0q3h3n9c195c9yysq5ccfb"))))
     (build-system gnu-build-system)
     (inputs `(("dmidecode" ,dmidecode)
               ("pciutils" ,pciutils)
@@ -55,7 +54,9 @@
               ("libftdi" ,libftdi)))
     (native-inputs `(("pkg-config" ,pkg-config)))
     (arguments
-     '(#:make-flags (list "CC=gcc" (string-append "PREFIX=" %output))
+     '(#:make-flags (list "CC=gcc"
+                          (string-append "PREFIX=" %output)
+                          "CONFIG_ENABLE_LIBUSB0_PROGRAMMERS=no")
        #:tests? #f   ; no 'check' target
        #:phases
        (alist-delete
diff --git a/gnu/packages/patches/flashrom-use-libftdi1.patch b/gnu/packages/patches/flashrom-use-libftdi1.patch
deleted file mode 100644
index a6051df..0000000
--- a/gnu/packages/patches/flashrom-use-libftdi1.patch
+++ /dev/null
@@ -1,70 +0,0 @@
-Update to libftdi-1.0 is advertised as a drop-in replacement for libftdi,
-running on top of libusb-1.0. This also removes indirect dependency to
-libusb-0.1.
-
-Patch by Kyösti Mälkki <kyosti.malkki@gmail.com>.
-See <http://patchwork.coreboot.org/patch/3904/>.
-
---- flashrom/Makefile.orig	2013-08-13 18:00:00.000000000 -0400
-+++ flashrom/Makefile	2014-08-05 03:10:40.217145375 -0400
-@@ -492,19 +492,21 @@
- ifeq ($(CONFIG_FT2232_SPI), yes)
- # This is a totally ugly hack.
- FEATURE_CFLAGS += $(shell LC_ALL=C grep -q "FTDISUPPORT := yes" .features && printf "%s" "-D'CONFIG_FT2232_SPI=1'")
--NEED_FTDI := yes
-+NEED_FTDI1 := yes
- PROGRAMMER_OBJS += ft2232_spi.o
- endif
- 
- ifeq ($(CONFIG_USBBLASTER_SPI), yes)
- # This is a totally ugly hack.
- FEATURE_CFLAGS += $(shell LC_ALL=C grep -q "FTDISUPPORT := yes" .features && printf "%s" "-D'CONFIG_USBBLASTER_SPI=1'")
--NEED_FTDI := yes
-+NEED_LIBUSB1 := yes
-+NEED_FTDI1 := yes
- PROGRAMMER_OBJS += usbblaster_spi.o
- endif
- 
--ifeq ($(NEED_FTDI), yes)
--FTDILIBS := $(shell pkg-config --libs libftdi 2>/dev/null || printf "%s" "-lftdi -lusb")
-+ifeq ($(NEED_FTDI1), yes)
-+FTDILIBS := $(shell pkg-config --libs libftdi1 2>/dev/null || printf "%s" "-lftdi1 -lusb-1.0")
-+FEATURE_CFLAGS += $(shell pkg-config --cflags libftdi1 2>/dev/null)
- FEATURE_CFLAGS += $(shell LC_ALL=C grep -q "FT232H := yes" .features && printf "%s" "-D'HAVE_FT232H=1'")
- FEATURE_LIBS += $(shell LC_ALL=C grep -q "FTDISUPPORT := yes" .features && printf "%s" "$(FTDILIBS)")
- # We can't set NEED_USB here because that would transform libftdi auto-enabling
-@@ -781,6 +783,7 @@
- endif
- 
- define FTDI_TEST
-+#include <stddef.h>
- #include <ftdi.h>
- struct ftdi_context *ftdic = NULL;
- int main(int argc, char **argv)
-@@ -793,6 +796,7 @@
- export FTDI_TEST
- 
- define FTDI_232H_TEST
-+#include <stddef.h>
- #include <ftdi.h>
- enum ftdi_chip_type type = TYPE_232H;
- endef
-@@ -826,15 +830,15 @@
- 
- features: compiler
- 	@echo "FEATURES := yes" > .features.tmp
--ifeq ($(NEED_FTDI), yes)
-+ifeq ($(NEED_FTDI1), yes)
- 	@printf "Checking for FTDI support... "
- 	@echo "$$FTDI_TEST" > .featuretest.c
--	@$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >/dev/null 2>&1 &&	\
-+	@$(CC) $(CPPFLAGS) $(CFLAGS) $(FEATURE_CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >/dev/null 2>&1 &&	\
- 		( echo "found."; echo "FTDISUPPORT := yes" >> .features.tmp ) ||	\
- 		( echo "not found."; echo "FTDISUPPORT := no" >> .features.tmp )
- 	@printf "Checking for FT232H support in libftdi... "
- 	@echo "$$FTDI_232H_TEST" >> .featuretest.c
--	@$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >/dev/null 2>&1 &&	\
-+	@$(CC) $(CPPFLAGS) $(CFLAGS) $(FEATURE_CFLAGS) $(LDFLAGS) .featuretest.c -o .featuretest$(EXEC_SUFFIX) $(FTDILIBS) $(LIBS) >/dev/null 2>&1 &&	\
- 		( echo "found."; echo "FT232H := yes" >> .features.tmp ) ||	\
- 		( echo "not found."; echo "FT232H := no" >> .features.tmp )
- endif

Re: [PATCH] gnu: Update flashrom to 0.9.9

[Leo Famulari]

On Wed, Sep 14, 2016 at 10:09:06PM +0200, Danny Milosavljevic wrote:
> 
> gnu: Update flashrom to 0.9.9
> 
> * gnu/packages/flashing-tools.scm (flashrom): Changed.
> * gnu/packages/patches/flashrom-use-libftdi1.patch: Removed.
> * gnu/local.mk: Remove mention of "flashrom-use-libftdi1.patch".

Thanks! I rewrote the commit message so it follows our conventions and
pushed.