From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add ding.
Date: Mon, 05 Sep 2016 23:05:15 +0200
Message-ID: <87fupeukfo.fsf@gnu.org>
References: <1472934380-4627-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52456)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bh151-0006Q0-Cm
	for guix-devel@gnu.org; Mon, 05 Sep 2016 17:05:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bh14v-00018q-WF
	for guix-devel@gnu.org; Mon, 05 Sep 2016 17:05:22 -0400
Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44918)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1bh14v-00018l-Sl
	for guix-devel@gnu.org; Mon, 05 Sep 2016 17:05:17 -0400
In-Reply-To: <1472934380-4627-1-git-send-email-jmd@gnu.org> (John Darrington's
	message of "Sat, 3 Sep 2016 22:26:20 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/dictionaries.scm (ding): New variable.

Please add a copyright line for yourself.

> +               ;; It seems that substitute* cannot handle this file.
> +               ;; ISO-8859-1 encoding ?
> +               (zero? (system*
> +                       "sed" "-i" "-e"
> +                       (string-append
> +                        "s%exec wish%" "exec " wish "%" ) "ding"))

Should work with:

  (with-fluids ((%default-port-encoding "ISO-8859-1"))
    (substitute* =E2=80=A6))

> +               (copy-file "ding.desktop"
> +                          (string-append sharedir "/ding.desktop"))

Rather: (install-file "ding.desktop" sharedir).

> +               (copy-file "ding.png"
> +                          (string-append sharedir "/ding.png"))

Likewise.

> +               (zero?
> +                (system* "./install.sh"))))))))
> +    (synopsis "Dictionary lookup program with a German-English dictionar=
y")
> +    (description "Ding is a dictionary lookup program for the X window s=
ystem.
> +It comes with a German-English dictionary with approximately 270,000 ent=
ries.")
> +    (home-page  "http://www-user.tu-chemnitz.de/~fri/ding/")
> +    (license gpl2+)))

OK with these changes.

Thank you!

Ludo=E2=80=99.