Re: [PATCH] gnu: Add ding.

[ludo@gnu.org (Ludovic Courtès)]

John Darrington <jmd@gnu.org> skribis:

> * gnu/packages/dictionaries.scm (ding): New variable.

Please add a copyright line for yourself.

> +               ;; It seems that substitute* cannot handle this file.
> +               ;; ISO-8859-1 encoding ?
> +               (zero? (system*
> +                       "sed" "-i" "-e"
> +                       (string-append
> +                        "s%exec wish%" "exec " wish "%" ) "ding"))

Should work with:

  (with-fluids ((%default-port-encoding "ISO-8859-1"))
    (substitute* …))

> +               (copy-file "ding.desktop"
> +                          (string-append sharedir "/ding.desktop"))

Rather: (install-file "ding.desktop" sharedir).

> +               (copy-file "ding.png"
> +                          (string-append sharedir "/ding.png"))

Likewise.

> +               (zero?
> +                (system* "./install.sh"))))))))
> +    (synopsis "Dictionary lookup program with a German-English dictionary")
> +    (description "Ding is a dictionary lookup program for the X window system.
> +It comes with a German-English dictionary with approximately 270,000 entries.")
> +    (home-page  "http://www-user.tu-chemnitz.de/~fri/ding/")
> +    (license gpl2+)))

OK with these changes.

Thank you!

Ludo’.