From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 5/5] gnu: linux-libre: Add support for cross-compilation.
Date: Mon, 05 Sep 2016 10:33:13 +0200
Message-ID: <87fupepwza.fsf@gnu.org>
References: <20160902160928.9458-1-david@craven.ch>
	<20160902160928.9458-6-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49249)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bgpLE-0008Rh-6h
	for guix-devel@gnu.org; Mon, 05 Sep 2016 04:33:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bgpLA-00043f-UG
	for guix-devel@gnu.org; Mon, 05 Sep 2016 04:33:20 -0400
In-Reply-To: <20160902160928.9458-6-david@craven.ch> (David Craven's message
	of "Fri, 2 Sep 2016 18:09:28 +0200")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

David Craven <david@craven.ch> skribis:

> * gnu/packages/linux.scm (linux-libre): Add support for
>   cross-compilation.

Awesome!  I suppose you tested it with:

  guix build --target=3Darm-linux-gnueabihf linux-libre

right?

Once this is committed, I=E2=80=99ll add it as a build job for Hydra.

> Sorry about this. I hadn't checked that cross compilation doesn't
> break native compiles. It should be (unless target (setenv ...

Right, don=E2=80=99t break native compiles.  :-)

Other than that the patch LGTM.  OK to commit if it works natively and
with the arm-linux-gnueabihf cross-compilation target!

> Also the patch with the arm config should also add armhf-linux to
> supported-systems

Good point.

Thank you!

Ludo=E2=80=99.