From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] gnu: Add emacs-es-mode
Date: Wed, 14 Sep 2016 16:37:03 +0200
Message-ID: <87fup2pmy8.fsf@gnu.org>
References: <20160913070624.28493-1-mail@cbaines.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39005)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bkBJN-0003eL-7m
	for guix-devel@gnu.org; Wed, 14 Sep 2016 10:37:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bkBJG-0007J2-LW
	for guix-devel@gnu.org; Wed, 14 Sep 2016 10:37:16 -0400
In-Reply-To: <20160913070624.28493-1-mail@cbaines.net> (Christopher Baines's
	message of "Tue, 13 Sep 2016 08:06:24 +0100")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: guix-devel@gnu.org

Christopher Baines <mail@cbaines.net> skribis:

> * gnu/packages/emacs.scm (emacs-es-mode): New variable.

I made minor changes:

> +    (inputs `(("guile" ,guile-2.0)))

I removed it since it=E2=80=99s unused, AFAICS.

> +    (propagated-inputs
> +     ; The version of org in Emacs 24.5 is not sufficient, and causes
> +     ; tables to be rendered incorrectly

Use =E2=80=9C;;=E2=80=9D.

> +    (description "es-mode includes highlighting, completion and indentat=
ion
> +support for Elasticsearch queries.  Also supported are es-mode blocks in
> +org-mode, for which the results of queries can be processed through jq, =
or
> +in the case of aggregations, can be rendered in to a table.  In addition,
> +there is a es-command-center mode, which displays information about
> +Elasticsearch clusters")

Used @code where appropriate and added missing period.

Pushed as 8bebe734ca54bf83ceae4db0a91f09a706562882, thanks!

Ludo=E2=80=99.