From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH 2/2] gnu: perl: Enable threading support.
Date: Sat, 24 Sep 2016 14:05:34 +0900
Message-ID: <87fuopriox.fsf@gnu.org>
References: <20160920045607.18936-1-donttrustben@gmail.com>
	<20160920045607.18936-3-donttrustben@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45841)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bnfQq-0002qE-60
	for guix-devel@gnu.org; Sat, 24 Sep 2016 01:23:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1bnfQo-0004Vl-6N
	for guix-devel@gnu.org; Sat, 24 Sep 2016 01:23:24 -0400
In-Reply-To: <20160920045607.18936-3-donttrustben@gmail.com> (Ben Woodcroft's
	message of "Tue, 20 Sep 2016 14:56:07 +1000")
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ben Woodcroft <donttrustben@gmail.com>
Cc: guix-devel@gnu.org

Ben Woodcroft <donttrustben@gmail.com> skribis:

> * gnu/packages/perl.scm (perl)[arguments]: Enable threading support.
> * gnu/packages/commencement.scm (perl-boot0): Do not inherit 'configure'
> phase from perl.

[...]

>                          "-Uinstallusrbinperl"
>                          "-Dinstallstyle=3Dlib/perl5"
>                          "-Duseshrplib"
> +                        "-Dusethreads"

Is -Dusethreads really needed?  I thought the default behavior was to
build pthread support if ./Configure detects it.  That would greatly
simplify things.

If not, a variant of what Eric suggests would be to honor
#:configure-flags in this phase, such that all you need is to provide
different #:configure-flags in perl-boot0.

HTH!

Ludo=E2=80=99.