From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roel Janssen <roel@gnu.org>
Subject: Re: [PATCH 03/16] gnu: Add python-jupyter-client.
Date: Tue, 01 Nov 2016 14:27:13 +0100
Message-ID: <87funbmitq.fsf@gnu.org>
References: <20161101122046.751-1-ricardo.wurmus@mdc-berlin.de>
	<20161101122046.751-4-ricardo.wurmus@mdc-berlin.de>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42664)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1c1Z4f-00021C-JI
	for guix-devel@gnu.org; Tue, 01 Nov 2016 09:25:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <roel@gnu.org>) id 1c1Z4b-0005nt-LS
	for guix-devel@gnu.org; Tue, 01 Nov 2016 09:25:57 -0400
In-reply-to: <20161101122046.751-4-ricardo.wurmus@mdc-berlin.de>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org


Ricardo Wurmus writes:

> * gnu/packages/python.scm (python-jupyter-client,
> python2-jupyter-client): New variables.
> ---
>  gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index da16647..09ce599 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -4525,6 +4525,38 @@ without using the configuration machinery.")
>  (define-public python2-jupyter-core
>    (package-with-python2 python-jupyter-core))
>  
> +(define-public python-jupyter-client
> +  (package
> +    (name "python-jupyter-client")
> +    (version "4.4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "jupyter_client" version))
> +       (sha256
> +        (base32
> +         "1vjjrpjw7k5sh982pbjnslv7byfbfazjw9g92jvs7dz5qbx556n9"))))
> +    (build-system python-build-system)
> +    ;; Tests fail because of missing native python kernel which I assume is
> +    ;; provided by the ipython package, which we cannot use because it would
> +    ;; cause a dependency cycle.
> +    (arguments `(#:tests? #f))
> +    (propagated-inputs
> +     `(("python-pyzmq" ,python-pyzmq)
> +       ("python-traitlets" ,python-traitlets)
> +       ("python-jupyter-core" ,python-jupyter-core)))
> +    (home-page "http://jupyter.org/")
> +    (synopsis "Jupyter protocol implementation and client libraries")
> +    (description
> +     "The @code{jupyter_client} package contains the reference implementation
> +of the Jupyter protocol.  It also provides client and kernel management APIs
> +for working with kernels, and the @code{jupyter kernelspec} entrypoint for
> +installing kernelspecs for use with Jupyter frontends.")
> +    (license license:bsd-3)))

Is "kernelspec" one word?  And should "kernelspecs" be "@code{kernelspec}s"?

> +
> +(define-public python2-jupyter-client
> +  (package-with-python2 python-jupyter-client))
> +
>  (define-public python-ipython
>    (package
>      (name "python-ipython")


Otherwise, LGTM!

Kind regards,
Roel Janssen