From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: Re: python2-traceback2, python2-linecache2 Date: Thu, 19 Jan 2017 16:01:43 +0100 Message-ID: <87fukf6qlk.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> References: <8737gxxza3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170118075305.29573-1-dannym@scratchpost.org> <20170118075305.29573-2-dannym@scratchpost.org> <874m0w9sj7.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170119102850.67bf3e21@scratchpost.org> <87lgu76w8j.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170119153412.6cacee8d@scratchpost.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUEDn-00031B-BK for guix-devel@gnu.org; Thu, 19 Jan 2017 10:01:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUEDj-00085R-F6 for guix-devel@gnu.org; Thu, 19 Jan 2017 10:01:51 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:58233) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cUEDj-00084h-9d for guix-devel@gnu.org; Thu, 19 Jan 2017 10:01:47 -0500 In-Reply-To: <20170119153412.6cacee8d@scratchpost.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Danny Milosavljevic Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > Hi, > >> The traceback2 module works on python3 as well. I don't think patching >> imports will be necessary? > > Maybe it works. However, I think it's silly to package a "traceback" > module for Python 3.5 which is a backport of the "traceback" module > included in the CPython 3.5 interpreter when we use the CPython 3.5 > interpreter in the first place. There are other modules extracted from python3 and packaged for python2+3. "enum34", "contextlib2", etc. AFAICT traceback was added already in 3.0: https://docs.python.org/3.0/library/traceback.html > Same for python-linecache2. > > Therefore, I would have another patchset which adds them for Python 2 > only and patches them out otherwise (s/traceback2/traceback/g). If a module written for python3 imports "traceback2", that won't work anyway with the standard library since it's called just "traceback". I would much rather package a "superfluous" module, instead of conditionally patching packages to use the built-in for python3 only. > Adding them for Python 3.5 would just be asking for them to become > outdated for no reason (they are part of Python 3.5 and will update > with it - their origin is Python 3.5). > > That said, I'm happy that this is being discussed - I'm not sure what > the right way to go forward is. Me neither :-) but it's obviously something we need to tackle eventually. Copied in Hartmut, maybe he's got some insight? >>But I see we don't currently have traceback2, so I'm fine with 1.4.0 >>for now just to avoid packaging it. The rest LGTM, let's get this >>[python-testtools] in! > > OK! ...and the rest of this series ;-) I wonder if we should update scipy and numpy while at it. Thoughts? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAliA1NcACgkQoqBt8qM6 VPrE5gf7BCrFA52adxlNaCvdNhwL4yvp1K6ofvvn89I82zfP3DncWVtJf7aeHp1T pARcJpn+NB3TygwC57/wdL1otfWinkfnuUWCgzmUk0AlvM1a72D8iMYAOsLLMTgM UvnQEqbOfpHvxFz1jwYOO031ovt5D10EE0mJNrPvaVbA862litlUE+/jwOD90imh kgJhUTJYA2NRvPx4W6khdKDLwND6KD1d7nvHR8zW8YlPP2dAbn5flYUrxP8B4KVK UEjOTtOwKEfaybmthcUwjTSbfQz9D4McVkPfoQyezlypfAgcw8TtZziJXHVKnCVy V6xFfgV/CEZmRMfl2RuolCIh903B3w== =rPk7 -----END PGP SIGNATURE----- --=-=-=--