Torproject software: Nyx (previously known as ARM)

Torproject software: Nyx (previously known as ARM)

[contact.ng0]

I packaged nyx (this used to be arm). And there's a problem.

Is someone interested in co-authoring this to get either the test suite pass (which seems optional to me) or fix their custom python setup install phase?

I know I don't want to sit on this for some more months, and Efraim has done some tor python software fixing before. Maybe you are interested?
I don't know how to CC with git send-email, so I hope you will notice this eventually.

[PATCH] gnu: Add nyx.

[contact.ng0]

From: ng0 <ng0@libertad.pw>

* gnu/packages/tor.scm (nyx): New variable.
---
 gnu/packages/tor.scm | 46 +++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 45 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
index 6f26f404b..8b03b14c6 100644
--- a/gnu/packages/tor.scm
+++ b/gnu/packages/tor.scm
@@ -2,7 +2,7 @@
 ;;; Copyright © 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org>
 ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
-;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016, 2017 ng0 <contact.ng0@cryptolab.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -28,11 +28,14 @@
   #:use-module (guix build-system python)
   #:use-module (gnu packages)
   #:use-module (gnu packages libevent)
+  #:use-module (gnu packages lsof)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages pcre)
   #:use-module (gnu packages python)
   #:use-module (gnu packages qt)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages dns)
+  #:use-module (gnu packages linux)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages w3m))
 
@@ -223,3 +226,44 @@ internet.  The other user just needs to use Tor Browser to download the file
 from you.")
     (license (list gpl3+
                    bsd-3)))) ; onionshare/socks.py
+
+;; The last release of arm was 5 years ago, meanwhile python3 support has
+;; been added and the software was renamed to nyx.
+(define-public nyx
+  (let ((commit "fea209127484d9b304b908a4711c9528b1d065bc")
+        (revision "1"))
+    (package
+      (name "nyx")
+      (version (string-append "1.4.5.0-" revision "." (string-take commit 7)))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://git.torproject.org/nyx.git")
+               (commit commit)))
+         (file-name (string-append name "-" version "-checkout"))
+         (sha256
+          (base32
+           "1g0l4988076xg5gs0x0nxzlg58rfx5g5agmklvyh4yp03vxncdb9"))))
+      (build-system python-build-system)
+      (arguments
+       `(#:tests? #f ;122 out of 228 fail because the tests need internet.
+         #:phases
+         (modify-phases %standard-phases
+           (replace 'install
+             (lambda _
+               (zero? (system* "python" "setup.py" "install")))))))
+      (inputs
+       `(("tor" ,tor)
+         ("python-stem" ,python-stem)))
+      ;; (native-inputs
+      ;;  `(("python-mock" ,python-mock)
+      ;;    ("lsof" ,lsof)
+      ;;    ("net-tools" ,net-tools)))
+    (home-page "https://www.atagar.com/arm/")
+    (synopsis "Ncurses-based status monitor for Tor relays")
+    (description
+     "Anonymizing relay monitor (arm) is a command line interface status
+monitor for Tor.  This functions much like top does for system usage,
+providing real time statistics.")
+    (license gpl3+))))
-- 
2.11.0

Re: [PATCH] gnu: Add nyx.

[contact.ng0]

There should be a cover letter... but I hope gnu.org just keeps
it and I don't see it here.

Thing is, tests are broken and their custom install phase is
broken too. I think Efraim has experience in fixing tor software
and it would be great if this doesn't fall into branch-sleep for
weeks or months here on my side.

contact.ng0@cryptolab.net writes:

> From: ng0 <ng0@libertad.pw>
>
> * gnu/packages/tor.scm (nyx): New variable.
> ---
>  gnu/packages/tor.scm | 46 +++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 45 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
> index 6f26f404b..8b03b14c6 100644
> --- a/gnu/packages/tor.scm
> +++ b/gnu/packages/tor.scm
> @@ -2,7 +2,7 @@
>  ;;; Copyright © 2013, 2014, 2015 Ludovic Courtès <ludo@gnu.org>
>  ;;; Copyright © 2014, 2015 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright © 2016 Efraim Flashner <efraim@flashner.co.il>
> -;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
> +;;; Copyright © 2016, 2017 ng0 <contact.ng0@cryptolab.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -28,11 +28,14 @@
>    #:use-module (guix build-system python)
>    #:use-module (gnu packages)
>    #:use-module (gnu packages libevent)
> +  #:use-module (gnu packages lsof)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages pcre)
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages qt)
>    #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages dns)
> +  #:use-module (gnu packages linux)
>    #:use-module (gnu packages tls)
>    #:use-module (gnu packages w3m))
>  
> @@ -223,3 +226,44 @@ internet.  The other user just needs to use Tor Browser to download the file
>  from you.")
>      (license (list gpl3+
>                     bsd-3)))) ; onionshare/socks.py
> +
> +;; The last release of arm was 5 years ago, meanwhile python3 support has
> +;; been added and the software was renamed to nyx.
> +(define-public nyx
> +  (let ((commit "fea209127484d9b304b908a4711c9528b1d065bc")
> +        (revision "1"))
> +    (package
> +      (name "nyx")
> +      (version (string-append "1.4.5.0-" revision "." (string-take commit 7)))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://git.torproject.org/nyx.git")
> +               (commit commit)))
> +         (file-name (string-append name "-" version "-checkout"))
> +         (sha256
> +          (base32
> +           "1g0l4988076xg5gs0x0nxzlg58rfx5g5agmklvyh4yp03vxncdb9"))))
> +      (build-system python-build-system)
> +      (arguments
> +       `(#:tests? #f ;122 out of 228 fail because the tests need internet.
> +         #:phases
> +         (modify-phases %standard-phases
> +           (replace 'install
> +             (lambda _
> +               (zero? (system* "python" "setup.py" "install")))))))
> +      (inputs
> +       `(("tor" ,tor)
> +         ("python-stem" ,python-stem)))
> +      ;; (native-inputs
> +      ;;  `(("python-mock" ,python-mock)
> +      ;;    ("lsof" ,lsof)
> +      ;;    ("net-tools" ,net-tools)))
> +    (home-page "https://www.atagar.com/arm/")
> +    (synopsis "Ncurses-based status monitor for Tor relays")
> +    (description
> +     "Anonymizing relay monitor (arm) is a command line interface status
> +monitor for Tor.  This functions much like top does for system usage,
> +providing real time statistics.")
> +    (license gpl3+))))
> -- 
> 2.11.0
>
>

-- 
♥Ⓐ  ng0 -- https://www.inventati.org/patternsinthechaos/

Re: [PATCH] gnu: Add nyx.

[Ludovic Courtès]

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

contact.ng0@cryptolab.net skribis:

> From: ng0 <ng0@libertad.pw>
>
> * gnu/packages/tor.scm (nyx): New variable.

I applied the changes below and then realized that it fails to build:

--8<---------------cut here---------------start------------->8---
starting phase `install'
running install
running build
running build_py
running install_lib
creating /gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/site-packages/nyx
/gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/distutils/dist.py:261: UserWarning: Unknown distribution option: 'install_requires'
  warnings.warn(msg)
error: could not create '/gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/site-packages/nyx': Permission denied
phase `install' failed after 0.9 seconds
--8<---------------cut here---------------end--------------->8---

Could you send an update?

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1830 bytes --]

diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
index 8b03b14c6..cbc857e48 100644
--- a/gnu/packages/tor.scm
+++ b/gnu/packages/tor.scm
@@ -227,16 +227,16 @@ from you.")
     (license (list gpl3+
                    bsd-3)))) ; onionshare/socks.py
 
-;; The last release of arm was 5 years ago, meanwhile python3 support has
-;; been added and the software was renamed to nyx.
+;; The last release of "arm" was 5 years ago, meanwhile python3 support has
+;; been added and the software was renamed to "nyx".
 (define-public nyx
   (let ((commit "fea209127484d9b304b908a4711c9528b1d065bc")
         (revision "1"))
     (package
       (name "nyx")
-      (version (string-append "1.4.5.0-" revision "." (string-take commit 7)))
-      (source
-       (origin
+      (version (string-append "1.4.5.0-"
+                              revision "." (string-take commit 7)))
+      (source (origin
                 (method git-fetch)
                 (uri (git-reference
                       (url "https://git.torproject.org/nyx.git")
@@ -256,14 +256,10 @@ from you.")
       (inputs
        `(("tor" ,tor)
          ("python-stem" ,python-stem)))
-      ;; (native-inputs
-      ;;  `(("python-mock" ,python-mock)
-      ;;    ("lsof" ,lsof)
-      ;;    ("net-tools" ,net-tools)))
       (home-page "https://www.atagar.com/arm/")
       (synopsis "Ncurses-based status monitor for Tor relays")
       (description
-     "Anonymizing relay monitor (arm) is a command line interface status
-monitor for Tor.  This functions much like top does for system usage,
-providing real time statistics.")
+       "Nyx (formerly Anonymizing Relay Monitor or \"arm\") is a command-line
+interface status monitor for Tor.  This functions much like top does for
+system usage, providing real time statistics.")
       (license gpl3+))))

Re: [PATCH] gnu: Add nyx.

[ng0]

Ludovic Courtès <ludo@gnu.org> writes:

> contact.ng0@cryptolab.net skribis:
>
>> From: ng0 <ng0@libertad.pw>
>>
>> * gnu/packages/tor.scm (nyx): New variable.
>
> I applied the changes below and then realized that it fails to build:
>
> --8<---------------cut here---------------start------------->8---
> starting phase `install'
> running install
> running build
> running build_py
> running install_lib
> creating /gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/site-packages/nyx
> /gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/distutils/dist.py:261: UserWarning: Unknown distribution option: 'install_requires'
>   warnings.warn(msg)
> error: could not create '/gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/site-packages/nyx': Permission denied
> phase `install' failed after 0.9 seconds
> --8<---------------cut here---------------end--------------->8---
>
> Could you send an update?

That's exactly why I have sent it. I can't make it build because
it requires work to be done by someone involved more in python
than I am.
Of course when I wait some more time maybe I'll get the idea,
meanwhile I prefer to keep this "up for grabs", but we both know
that this almost never works out.

I also have an arm package, but I would prefer to get this
distributed rather than arm (arm also requires too much
patching).

I will consider your changes and see if I can fix it some day or
if someone else grabs it. It's all distraction from more
important tasks anyway.

> Thanks,
> Ludo’.
>
> diff --git a/gnu/packages/tor.scm b/gnu/packages/tor.scm
> index 8b03b14c6..cbc857e48 100644
> --- a/gnu/packages/tor.scm
> +++ b/gnu/packages/tor.scm
> @@ -227,16 +227,16 @@ from you.")
>      (license (list gpl3+
>                     bsd-3)))) ; onionshare/socks.py
>  
> -;; The last release of arm was 5 years ago, meanwhile python3 support has
> -;; been added and the software was renamed to nyx.
> +;; The last release of "arm" was 5 years ago, meanwhile python3 support has
> +;; been added and the software was renamed to "nyx".
>  (define-public nyx
>    (let ((commit "fea209127484d9b304b908a4711c9528b1d065bc")
>          (revision "1"))
>      (package
>        (name "nyx")
> -      (version (string-append "1.4.5.0-" revision "." (string-take commit 7)))
> -      (source
> -       (origin
> +      (version (string-append "1.4.5.0-"
> +                              revision "." (string-take commit 7)))
> +      (source (origin
>                  (method git-fetch)
>                  (uri (git-reference
>                        (url "https://git.torproject.org/nyx.git")
> @@ -256,14 +256,10 @@ from you.")
>        (inputs
>         `(("tor" ,tor)
>           ("python-stem" ,python-stem)))
> -      ;; (native-inputs
> -      ;;  `(("python-mock" ,python-mock)
> -      ;;    ("lsof" ,lsof)
> -      ;;    ("net-tools" ,net-tools)))
>        (home-page "https://www.atagar.com/arm/")
>        (synopsis "Ncurses-based status monitor for Tor relays")
>        (description
> -     "Anonymizing relay monitor (arm) is a command line interface status
> -monitor for Tor.  This functions much like top does for system usage,
> -providing real time statistics.")
> +       "Nyx (formerly Anonymizing Relay Monitor or \"arm\") is a command-line
> +interface status monitor for Tor.  This functions much like top does for
> +system usage, providing real time statistics.")
>        (license gpl3+))))

-- 
♥Ⓐ  ng0 -- https://www.inventati.org/patternsinthechaos/

Re: [PATCH] gnu: Add nyx.

[Ricardo Wurmus]

ng0 <contact.ng0@cryptolab.net> writes:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> contact.ng0@cryptolab.net skribis:
>>
>>> From: ng0 <ng0@libertad.pw>
>>>
>>> * gnu/packages/tor.scm (nyx): New variable.
>>
>> I applied the changes below and then realized that it fails to build:
>>
>> --8<---------------cut here---------------start------------->8---
>> starting phase `install'
>> running install
>> running build
>> running build_py
>> running install_lib
>> creating /gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/site-packages/nyx
>> /gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/distutils/dist.py:261: UserWarning: Unknown distribution option: 'install_requires'
>>   warnings.warn(msg)
>> error: could not create '/gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/site-packages/nyx': Permission denied
>> phase `install' failed after 0.9 seconds
>> --8<---------------cut here---------------end--------------->8---
>>
>> Could you send an update?
>
> That's exactly why I have sent it. I can't make it build because
> it requires work to be done by someone involved more in python
> than I am.

In that case please don’t include “[PATCH]” in the subject line.  There
are many patches that need to be reviewed and it’s a drain on our
limited resources to review patches that don’t yet result in buildable
code.

I consider “[PATCH]” emails as delayed commits.  We all have work in
progress and it doesn’t make sense to share it early as it just
displaces patches that are ready for review.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Re: [PATCH] gnu: Add nyx.

[ng0]

Ricardo Wurmus <rekado@elephly.net> writes:

> ng0 <contact.ng0@cryptolab.net> writes:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> contact.ng0@cryptolab.net skribis:
>>>
>>>> From: ng0 <ng0@libertad.pw>
>>>>
>>>> * gnu/packages/tor.scm (nyx): New variable.
>>>
>>> I applied the changes below and then realized that it fails to build:
>>>
>>> --8<---------------cut here---------------start------------->8---
>>> starting phase `install'
>>> running install
>>> running build
>>> running build_py
>>> running install_lib
>>> creating /gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/site-packages/nyx
>>> /gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/distutils/dist.py:261: UserWarning: Unknown distribution option: 'install_requires'
>>>   warnings.warn(msg)
>>> error: could not create '/gnu/store/alk9r3rir93pjmv8im20f8xrvv90219z-python-3.5.2/lib/python3.5/site-packages/nyx': Permission denied
>>> phase `install' failed after 0.9 seconds
>>> --8<---------------cut here---------------end--------------->8---
>>>
>>> Could you send an update?
>>
>> That's exactly why I have sent it. I can't make it build because
>> it requires work to be done by someone involved more in python
>> than I am.
>
> In that case please don’t include “[PATCH]” in the subject line.  There
> are many patches that need to be reviewed and it’s a drain on our
> limited resources to review patches that don’t yet result in buildable
> code.

That's automatically handled by git send-email.. I can't really
control what subject the second email AFTER the cover-leter gets.
But I'm looking for a way to improve this.

Now on nyx, I will give it another try. It might take a bit
longer though.

> I consider “[PATCH]” emails as delayed commits.  We all have work in
> progress and it doesn’t make sense to share it early as it just
> displaces patches that are ready for review.
>
> --
> Ricardo
>
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
>

-- 
♥Ⓐ  ng0 -- https://www.inventati.org/patternsinthechaos/

Re: [PATCH] gnu: Add nyx.

[Ricardo Wurmus]

ng0 <contact.ng0@cryptolab.net> writes:

> Ricardo Wurmus <rekado@elephly.net> writes:
[…]
>> In that case please don’t include “[PATCH]” in the subject line.  There
>> are many patches that need to be reviewed and it’s a drain on our
>> limited resources to review patches that don’t yet result in buildable
>> code.
>
> That's automatically handled by git send-email.. I can't really
> control what subject the second email AFTER the cover-leter gets.

“git format-patch” has an option “--subject-prefix=<Subject-Prefix>”.
You can then send the formatted patches with “git send-email”.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net