From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Huang\, Ying" Subject: Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3 Date: Mon, 06 Feb 2017 18:28:20 +0800 Message-ID: <87fujrehq3.fsf@163.com> References: <20170130030649.1716-1-huang_ying_caritas@163.com> <87h948yvlw.fsf@elephly.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cagXG-0002fk-D4 for guix-devel@gnu.org; Mon, 06 Feb 2017 05:28:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cagXD-0007As-9H for guix-devel@gnu.org; Mon, 06 Feb 2017 05:28:38 -0500 Received: from m12-11.163.com ([220.181.12.11]:58744) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cagXC-0007A2-Cg for guix-devel@gnu.org; Mon, 06 Feb 2017 05:28:35 -0500 In-Reply-To: <87h948yvlw.fsf@elephly.net> (Ricardo Wurmus's message of "Mon, 06 Feb 2017 02:08:11 +0100") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ricardo Wurmus Cc: guix-devel@gnu.org Hi, Ricardo, Ricardo Wurmus writes: > huang_ying_caritas@163.com writes: > >> From: Huang Ying >> >> Gtk+3 now have multiple outputs, so the gtk-query-immodules-3.0 should be find >> in bin output. > > Ah, I was wondering why this broke! Thanks for investigating it. > >> The fix works, but appears hacky, because I haven't read much guix source >> code, so I don't know the best solution. > > It’s only hacky because I tried to reuse the code for both versions of > Gtk. Maybe “gtk+-2” should also get a “bin” output…? That sounds reasonable for me. > This is acceptable with the changes Danny suggested. Maybe we can find > a way to make this prettier in the future. I have sent out -v3 which addressed Danny's comments with the following subject, [PATCH -v3] Fix gtk-im-modules for gtk+3 > Thanks again for taking the time to investigate and fix it, and to > submit a patch! I’m very grateful for this contribution. You are welcome! Best Regards, Huang, Ying > -- > Ricardo > > GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC > https://elephly.net