From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Subject: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
Date: Thu, 02 Mar 2017 22:00:47 +0100
Message-ID: <87fuivxukg.fsf@lassieur.org>
References: <20170219185431.zgn53ndcbpedrgo7@wasp>
	<20170220235355.29115-1-clement@lassieur.org>
	<20170220235355.29115-5-clement@lassieur.org>
	<20170302084448.2ff6ce96@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50532)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1cjXqJ-0004uh-Ou
	for guix-devel@gnu.org; Thu, 02 Mar 2017 16:00:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <clement@lassieur.org>) id 1cjXqG-0003pO-Ol
	for guix-devel@gnu.org; Thu, 02 Mar 2017 16:00:55 -0500
Received: from mail.lassieur.org ([83.152.10.219]:36804)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <clement@lassieur.org>)
	id 1cjXqG-0003o5-Ez
	for guix-devel@gnu.org; Thu, 02 Mar 2017 16:00:52 -0500
In-reply-to: <20170302084448.2ff6ce96@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: guix-devel@gnu.org

Hi Danny,

Danny Milosavljevic <dannym@scratchpost.org> writes:

> Hi,
>
> On Tue, 21 Feb 2017 00:53:55 +0100
> Cl=C3=A9ment Lassieur <clement@lassieur.org> wrote:
>> +This is a list of two-element tuples,=20
>
> list of pairs.
>
>>where each tuple contains the
>
> each pair
>
>> +subsystem name and a command (with optional arguments) to execute upo=
n
>> +subsystem request.
>> +
>> +The command @command{sftp-server} implements the SFTP file transfer
>> +subsystem.
>> +@example
>> +'(("sftp" "/usr/libexec/sftp-server"))
>
> Hmm, that is a list in there, not a two-element tuple:
>
> scheme@(guile-user)> (car '(("A" "B")))
> $1 =3D ("A" "B")
> scheme@(guile-user)> (car (car '(("A" "B"))))
> $3 =3D "A"
> scheme@(guile-user)> (cdr (car '(("A" "B"))))
> $2 =3D ("B")  <---- should be "B" without the parens for tuples
>
> So I suggest either fix the example to be a pair ("sftp" . "/usr/libexe=
c/sftp-server") or fix the docs.

Ok.  I'll correct this later, for now I don't want to push this patch,
I'm waiting for a confirmation from ng0.

Thanks for the review!