From: Alex Kost <alezost@gmail.com>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 26678@debbugs.gnu.org
Subject: bug#26678: [PATCH] gnu: Add emacs-gnuplot-mode.
Date: Sat, 29 Apr 2017 17:10:54 +0300 [thread overview]
Message-ID: <87fugrtic1.fsf@gmail.com> (raw)
In-Reply-To: <1cae0c94.AEMAJrDSELsAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZAcc4@mailjet.com> (Arun Isaac's message of "Thu, 27 Apr 2017 15:55:25 +0530")
Arun Isaac (2017-04-27 15:55 +0530) wrote:
> * gnu/packages/emacs.scm (emacs-gnuplot-mode): New variable.
> ---
> gnu/packages/emacs.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
Thanks! The patch looks good to me, the only thing: it would be good to
generate "…-autoloads.el" file (see below) to make "M-x gnuplot-mode"
available right away, otherwise a user has to adjust ".emacs" to
autoload it.
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 14d851184..b5307f56a 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -4519,3 +4519,33 @@ It should enable you to implement low-level X11 applications.")
> (description "EXWM is a full-featured tiling X window manager for Emacs
> built on top of XELB.")
> (license license:gpl3+)))
> +
> +(define-public emacs-gnuplot-mode
> + (package
> + (name "emacs-gnuplot-mode")
BTW this package is called "gnuplot" on MELPA, because there is another
"gnuplot-mode" (also available on MELPA):
https://github.com/mkmcc/gnuplot-mode
Perhaps we should stick to the MELPA names, otherwise it may be
confusing if we call this package "gnuplot-mode", WDYT?
> + (version "0.7.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "https://github.com/bruceravel/gnuplot-mode/archive/"
> + version ".tar.gz"))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "0glzymrn138lwig7p4cj17x4if5jisr6l4g6wcbxisqkqgc1h01i"))))
> + (build-system gnu-build-system)
> + (native-inputs `(("emacs" ,emacs-minimal)))
> + (arguments
> + `(#:configure-flags
> + (list (string-append "EMACS=" (assoc-ref %build-inputs "emacs")
> + "/bin/emacs")
> + (string-append "--with-lispdir="
> + (assoc-ref %outputs "out")
> + "/share/emacs/site-lisp/guix.d/gnuplot-mode-"
> + ,version))))
To generate "autoloads.el", the 'arguments' could be written like this:
(arguments
(let ((elisp-dir (string-append "/share/emacs/site-lisp/guix.d"
"/gnuplot-mode-" version)))
`(#:modules ((guix build gnu-build-system)
(guix build utils)
(guix build emacs-utils))
#:imported-modules (,@%gnu-build-system-modules
(guix build emacs-utils))
#:configure-flags
(list (string-append "EMACS=" (assoc-ref %build-inputs "emacs")
"/bin/emacs")
(string-append "--with-lispdir=" %output ,elisp-dir))
#:phases
(modify-phases %standard-phases
(add-after 'install 'generate-autoloads
(lambda* (#:key outputs #:allow-other-keys)
(emacs-generate-autoloads
"gnuplot"
(string-append (assoc-ref outputs "out") ,elisp-dir))
#t))))))
> + (home-page "https://github.com/bruceravel/gnuplot-mode")
> + (synopsis "Emacs major mode for interacting with gnuplot")
> + (description "@code{emacs-gnuplot-mode} is an emacs major mode for
> +interacting with gnuplot.")
> + (license license:gpl2+)))
--
Alex
next prev parent reply other threads:[~2017-04-29 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 10:25 bug#26678: [PATCH] gnu: Add emacs-gnuplot-mode Arun Isaac
2017-04-29 14:10 ` Alex Kost [this message]
2017-05-01 14:13 ` Arun Isaac
2017-05-02 9:17 ` Alex Kost
2017-05-03 19:26 ` Arun Isaac
2017-05-01 14:08 ` bug#26678: [PATCH] gnu: Add emacs-gnuplot Arun Isaac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fugrtic1.fsf@gmail.com \
--to=alezost@gmail.com \
--cc=26678@debbugs.gnu.org \
--cc=arunisaac@systemreboot.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.