From: ludo@gnu.org (Ludovic Courtès)
To: "Clément Lassieur" <clement@lassieur.org>
Cc: 26734@debbugs.gnu.org
Subject: bug#26734: Snippets (even empty ones) of tar sources reset the timestamps of all files
Date: Wed, 03 May 2017 10:58:59 +0200 [thread overview]
Message-ID: <87fugmxqng.fsf@gnu.org> (raw)
In-Reply-To: <87d1brmm8m.fsf@lassieur.org> ("Clément Lassieur"'s message of "Tue, 02 May 2017 15:17:29 +0200")
Clément Lassieur <clement@lassieur.org> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Clément Lassieur <clement@lassieur.org> skribis:
>>
>>> I tried to patch 'patch-and-repack', but it triggers a full
>>> rebuild... WDYT?
>>
>> Right, it’s expected to trigger a full rebuild, so this should be fixed
>> in ‘core-updates’.
>
> Yes, but is there a way to test the patch on one package without having
> first to rebuild everything?
I would add a snippet in ‘gnu-make-boot0’, which is the first package
being built, and then run:
./pre-inst-env guix build -S --rounds=2 \
-e '(@@ (gnu packages commencement) gnu-make-boot0)'
>> I guess we’ll have to collect the timestamps of all non-symlink files¹
>> in step #1 and to reapply them with ‘set-file-time’ from (guix build
>> utils) after step #2.
>
> Does that mean that symlinks will still have their timestamps changed?
No, that means symlinks will still have their timestamps unchanged. :-)
BTW, what timestamps to we put on the modified files? We want that to
be deterministic so we cannot use the build time. We cannot use a date
in the future, either. We cannot use Jan. 1 1970 either because that
means that modified files may now be older than the unmodified files,
which may break build systems; for the same reason, we cannot leave the
mtime of modified files unchanged.
Now that I think about it, it’s not clear to me what can be done without
breaking something.
Thoughts?
>> ¹ Because Guile provides bindings for ‘utime’, which does not support
>> setting timestamps on symlinks.
>
> If the guile binding doesn't support setting timestamps on symlinks, I
> guess we can still use another way, like a system touch.
Or we could add bindings for ‘futimes’.
Thanks,
Ludo’.
next prev parent reply other threads:[~2017-05-03 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 13:57 bug#26734: Snippets (even empty ones) of tar sources reset the timestamps of all files Clément Lassieur
2017-05-02 13:00 ` Ludovic Courtès
2017-05-02 13:17 ` Clément Lassieur
2017-05-03 8:58 ` Ludovic Courtès [this message]
2017-05-03 21:45 ` Mark H Weaver
2017-05-03 22:01 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fugmxqng.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=26734@debbugs.gnu.org \
--cc=clement@lassieur.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.