From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48539) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dExTO-0003nE-5n for guix-patches@gnu.org; Sun, 28 May 2017 08:39:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dExTK-0004QR-8V for guix-patches@gnu.org; Sun, 28 May 2017 08:39:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:38626) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dExTK-0004QL-4Y for guix-patches@gnu.org; Sun, 28 May 2017 08:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dExTJ-0001gH-Vo for guix-patches@gnu.org; Sun, 28 May 2017 08:39:01 -0400 Subject: bug#26941: New font-build-system Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87bbe3e5.AEAAKL2r-KIAAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZGcQo@mailjet.com> <87y3tw4kw3.fsf@gnu.org> <87r2zfx0xt.fsf@gnu.org> <9591bf82.AEUAKjfDcSkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZKceD@mailjet.com> Date: Sun, 28 May 2017 14:38:38 +0200 In-Reply-To: <9591bf82.AEUAKjfDcSkAAAAAAAAAAAOzWv8AAAACwQwAAAAAAAW9WABZKceD@mailjet.com> (Arun Isaac's message of "Sun, 28 May 2017 00:07:38 +0530") Message-ID: <87fufptaup.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Arun Isaac Cc: 26941@debbugs.gnu.org Arun Isaac skribis: >>> A side issue: I feel that the `install-file' procedure should print out >>> what it's doing to stdout (or some log port). Something like: >>> >>> (format #t "~a -> ~a~%" source destination) >>> >>> This would save us the trouble of implementing this log printing >>> everywhere `install-file' is called. For example, this could be very >>> useful in the 'install' phase of the font-build-sytem. WDYT? >> >> Do we really need to print something in the first place? :-) Some >> procedures in (guix build utils) do that, indeed, but I=E2=80=99m not su= re it=E2=80=99s >> useful for something as simple as =E2=80=98install-file=E2=80=99. Thoug= hts? > > Yes, I think it is really important. Without the verbose output, one > will have to stare at a blank screen, guessing at what is > happening. Long verbose output feels reassuring that something is going > on. :-) Also, verbose output for `install-file' might help in debugging > correct source/destination paths. OK. I=E2=80=99m not entirely convinced, because I think that either the bu= ild completes and it=E2=80=99s easy to check that the files are where you wanted them to be, or it fails, and you get an exception. I=E2=80=99m not strongly opposed either, so perhaps something to consider in the next =E2=80=98core-updates=E2=80=99 cycle. >>> + ,@(let ((compression (resolve-module '(gnu packages= compression)))) >>> + (map (match-lambda >>> + ((name package) >>> + (list name (module-ref compression pack= age)))) >>> + `(("tar" tar) >>> + ("gzip" gzip) >>> + ("bzip2" bzip2) >>> + ("xz" xz)))))) >> >> This works, but since =E2=80=98tar=E2=80=99 is defined in (gnu packages = base), it=E2=80=99s >> better to take it from there. > > Done! I have also included "unzip" because several font packages come as > zip archives. WDYT? Makes sense! > From a0bda2fc48c6d2c7809805251154c49e8be76d67 Mon Sep 17 00:00:00 2001 > From: Arun Isaac > Date: Mon, 15 May 2017 20:08:57 +0530 > Subject: [PATCH 1/5] build-system: Add 'font-build-system'. > > * Makefile.am (MODULES): Add 'guix/build-system/font.scm' and > 'guix/build/font-build-system.scm'. > * guix/build-system/font.scm: New file. > * guix/build/font-build-system.scm: New file. > * doc/guix.texi (Build Systems): Add 'font-build-system'. Alright, OK for this and the following patches. Thank you! Ludo=E2=80=99.