From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dMesk-0005yQ-0G for guix-patches@gnu.org; Sun, 18 Jun 2017 14:25:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dMesg-0003dU-Op for guix-patches@gnu.org; Sun, 18 Jun 2017 14:25:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:52679) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dMesg-0003d0-CT for guix-patches@gnu.org; Sun, 18 Jun 2017 14:25:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dMesg-0003Gx-2Q for guix-patches@gnu.org; Sun, 18 Jun 2017 14:25:02 -0400 Subject: [bug#27421] [PATCH 4/5] gnu: Add openttd-opengfx. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20170618174519.32747-3-kei@openmailbox.org> References: <20170618174519.32747-1-kei@openmailbox.org> <20170618174519.32747-3-kei@openmailbox.org> Date: Sun, 18 Jun 2017 20:24:25 +0200 Message-ID: <87fuexf92e.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Kei Kebreau , 27421@debbugs.gnu.org --=-=-= Content-Type: text/plain Kei Kebreau writes: > * gnu/packages/games.scm (openttd-opengfx): New variable. [...] > + ;; Redirect stdout to /dev/null instead of stderr. This prevents > + ;; dos2unix from receiving its version information as a flag. > + (substitute* "Makefile" > + (("\\$\\(UNIX2DOS\\) -q --version 2>/dev/null") > + "$(UNIX2DOS) -q --version 1>/dev/null"))))) I'm a bit confused as to why this is necessary. I guess it's a behavior change in recent versions, that --version prints on stdout? LGTM anyway. > + ;; The check phase for this package only checks the md5sums of the built > + ;; GRF files against the md5sums of the release versions. Because we use > + ;; different software versions than upstream does, some of the md5sums > + ;; are different. However, the package is still reproducible, it's safe > + ;; to disable this test. > + #:tests? #f)) > + (native-inputs `(("dos2unix" ,dos2unix) > + ("gimp" ,gimp) > + ("grfcodec" ,grfcodec) > + ("nml" ,nml) > + ("python" ,python-2))) > + (home-page "http://dev.openttdcoop.org/projects/opengfx") > + (synopsis "Base graphics set for OpenTTD") > + (description > + "The OpenGFX project is a free replacement of the base graphics so that > +OpenTTD can be shipped finally fully functional without the need for additional > +downloads.") Yay! I'm thinking we should mention this is one of many available grahics sets for OpenTTD. Maybe something like.. "The OpenGFX projects is an implementation of the OpenTTD base grahics set that aims to ensure the best possible out-of-the-box experience. OpenGFX provides you with... @enumerate @item All graphics you need to enjoy OpenTTD. @item Uniquely drawn rail vehicles for every climate. @item Completely snow-aware rivers. @item Different river and sea water. @item Snow-aware buoys. @end enumerate" (Adapted from readme.ptxt) > + (license license:gpl2))) Indeed version 2 only. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAllGxVkACgkQoqBt8qM6 VPoGTgf/QfJrtd/rmH54usVjoThLzU7ehf/coO1qkXOsnfK9yxhSNivtPrx83nTB w1iBvkVt7liW30Vlxd94f89UTPyY8zHtv+i7sW2uuohYHtbK4pYirC9NL0wAdb3C tz6Hk8+Al+4wS8a8JVR8eBPrOWz1J0LKq5q8cVJsrwoKIhRSFVaSA9ZiQgMk13bf r20MXXePYxNSghp5kh3anELQqfptjAFivigXp8j1uhLTgSUDTofcXsQXqL5LUVg6 W+lbr6wK521mg2RoQxdWAQbdLNrjFHyYHsNsqnBAeQYfcHgmWtWJbPnteZ+wcBWl 0GcKUDMPUVn6oX0HM6BPKzgblud6ew== =ucSE -----END PGP SIGNATURE----- --=-=-=--