From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#27593: [PATCH] gnu: groff: Make build reproducible.
Date: Tue, 11 Jul 2017 11:31:12 +0200
Message-ID: <87fue3xqu7.fsf@gnu.org>
References: <20170706025451.312ddebe@scratchpost.org>
	<20170710163704.25613-1-dannym@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44808)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dUrWX-0004Dv-7T
	for bug-guix@gnu.org; Tue, 11 Jul 2017 05:32:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dUrWU-00088o-45
	for bug-guix@gnu.org; Tue, 11 Jul 2017 05:32:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:58938)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dUrWU-00088g-08
	for bug-guix@gnu.org; Tue, 11 Jul 2017 05:32:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dUrWT-00026i-Qm
	for bug-guix@gnu.org; Tue, 11 Jul 2017 05:32:01 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.27593.B27593.14997654848054@debbugs.gnu.org>
In-Reply-To: <20170710163704.25613-1-dannym@scratchpost.org> (Danny
	Milosavljevic's message of "Mon, 10 Jul 2017 18:37:04 +0200")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 27593@debbugs.gnu.org

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> * gnu/packages/groff.scm (groff)[arguments]: Add phase "setenv".
> ---
>  gnu/packages/groff.scm | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/groff.scm b/gnu/packages/groff.scm
> index 67dd1dbfa..6e1a60e9b 100644
> --- a/gnu/packages/groff.scm
> +++ b/gnu/packages/groff.scm
> @@ -56,7 +56,14 @@
>                      ("perl" ,perl)
>                      ("psutils" ,psutils)
>                      ("texinfo" ,texinfo)))
> -   (arguments '(#:parallel-build? #f))  ; parallel build fails
> +   (arguments
> +    `(#:parallel-build? #f   ; parallel build fails
> +      #:phases
> +      (modify-phases %standard-phases
> +        (add-after 'unpack 'setenv
> +          (lambda _
> +            (setenv "GS_GENERATE_UUIDS" "0")
> +            #t)))))

With a comment like Marius wrote, it=E2=80=99d be perfect; otherwise LGTM.

However, since =E2=80=98core-updates=E2=80=99 is now building and we=E2=80=
=99d like to make
progress on it, could you push it to =E2=80=98core-updates-next=E2=80=99 or=
 similar?

Thanks,
Ludo=E2=80=99.