From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45889)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dw9ab-0005NZ-TJ
	for guix-patches@gnu.org; Sun, 24 Sep 2017 12:17:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dw9aY-0002FO-Np
	for guix-patches@gnu.org; Sun, 24 Sep 2017 12:17:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:47587)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dw9aY-0002FE-KW
	for guix-patches@gnu.org; Sun, 24 Sep 2017 12:17:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dw9aY-0005EW-DR
	for guix-patches@gnu.org; Sun, 24 Sep 2017 12:17:02 -0400
Subject: [bug#28579] gpa
Resent-Message-ID: <handler.28579.B28579.150626976820049@debbugs.gnu.org>
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
In-Reply-To: <20170924155452.lsq7mbnbuwa6clei@abyayala>
	(ng0@infotropique.org's message of "Sun, 24 Sep 2017 15:54:52 +0000")
References: <20170924155452.lsq7mbnbuwa6clei@abyayala>
Date: Sun, 24 Sep 2017 18:16:02 +0200
Message-ID: <87fubc5ayl.fsf@nicolasgoaziou.fr>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: ng0 <ng0@infotropique.org>
Cc: 28579@debbugs.gnu.org

Hello,

ng0 <ng0@infotropique.org> writes:

> A GUI for GnuPG.
>
> Builds.
> GUI works, Preferences pick up my $HOME/.gnupg settings.
> More wasn't tested.

Thank you. I have some comments about your patch.

> +(define-public gpa
> +  (package
> +    (name "gpa")
> +    (version "0.9.9")

version 0.9.10 is out since 2016. Would it make sense to package it instead?

> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "ftp://ftp.gnupg.org/gcrypt/gpa/"
> +                          name "-" version ".tar.bz2"))

Guix lint reports:

  URL should be "mirror://gnupg/gpa/gpa-0.9.9.tar.bz2"

> +      (sha256
> +       (base32
> +        "0d235hcqai7m3qb7m9kvr2r4qg4714f87j9fdplwrlz1p4wdfa38"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("gnupg" ,gnupg)
> +       ("gpgme" ,gpgme)
> +       ("libassuan" ,libassuan)
> +       ("libgpg-error" ,libgpg-error)
> +       ("gtk+-2" ,gtk+-2)))
> +    (home-page "https://gnupg.org/software/gpa/index.html")
> +    (synopsis "GUI for GnuPG")
> +    (description
> +     "@defn{GNU Privacy Assistant} (GPA) is a graphical user
> +interface for the @defn{GNU Privacy Guard} (GnuPG).")

Guix lint reports an error about invalid Texinfo markup.

I'm not sure about what to do to fix it, if there is anything to do at
all. IMO, @defn is not adequate here.

> +    (license license:gpl3)))

Every ".c" file I checked use "or any later version". I think this
should be "gpl3+". WDYT?

Regards,

-- 
Nicolas Goaziou                                                0x80A93738