From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47799)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4vKr-0007qc-RC
	for guix-patches@gnu.org; Wed, 18 Oct 2017 16:53:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4vKo-0006VG-Mc
	for guix-patches@gnu.org; Wed, 18 Oct 2017 16:53:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40009)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e4vKo-0006V7-JE
	for guix-patches@gnu.org; Wed, 18 Oct 2017 16:53:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4vKo-0006Pw-Bk
	for guix-patches@gnu.org; Wed, 18 Oct 2017 16:53:02 -0400
Subject: [bug#28841] [PATCH 02/24] =?UTF-8?Q?gnu:=C2=A0Add?= java-tomcat.
Resent-Message-ID: <handler.28841.B28841.150835995224611@debbugs.gnu.org>
References: <20171014233216.49c852f7@lepiller.eu>
	<20171014222349.12902-1-julien@lepiller.eu>
	<20171014222349.12902-2-julien@lepiller.eu>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20171014222349.12902-2-julien@lepiller.eu>
Date: Wed, 18 Oct 2017 22:36:59 +0200
Message-ID: <87fuag42hg.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: julien@lepiller.eu
Cc: 28841@debbugs.gnu.org


Hi Julien,

> From: Julien Lepiller <julien@lepiller.eu>
>
> * gnu/packages/java.scm (java-tomcat): New variable.

Impressive!

> +    (build-system ant-build-system)
> +    (inputs
> +     `(("java-eclipse-jdt-core" ,java-eclipse-jdt-core)))

Note to self: we still need to fix the ant-build-system to install a
file containing plain-text references to all inputs to prevent them from
being garbage collected.

> +    (native-inputs
> +     `(("java-junit" ,java-junit)))
> +    (arguments
> +     `(#:build-target "package"
> +       #:tests? #f; requires downloading some files.
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'properties
> +           (lambda _
> +             (mkdir "downloads")
> +             (substitute* "build.xml"
> +               (("download-compile,") "")
> +               (("depends=\"validate\"") "depends=\"build-prepare\"")
> +               ((",download-validate") ""))

Could you add a comment here to explain why this is needed?

> +             (with-output-to-file "build.properties"
> +               (lambda _
> +                 (display
> +                   (string-append "base.path=" (getcwd)
> "/downloads\n"))))))

I prefer using the make-flags here to set the base.path property.  Have
you tried that?

> +    (description "Apache Tomcat is an open source implementation of the Java
> +Servlet, JavaServer Pages, Java Expression Language and Java WebSocket
> +technologies.  The Java Servlet, JavaServer Pages, Java Expression Language and
> +Java WebSocket specifications are developed under the Java Community
> Process.")

“Open source”, eh? :)  Please just write “[…] is an implementation of
the […]”.  The second sentence is a bit odd.  I don’t think that’s
information that belongs in a package description.

Thanks!

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net