From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eEvrR-0000pH-8p for guix-patches@gnu.org; Wed, 15 Nov 2017 06:28:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eEvrO-0007s4-LF for guix-patches@gnu.org; Wed, 15 Nov 2017 06:28:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:60588) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eEvrO-0007rl-H5 for guix-patches@gnu.org; Wed, 15 Nov 2017 06:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eEvrO-0008Q4-5V for guix-patches@gnu.org; Wed, 15 Nov 2017 06:28:02 -0500 Subject: [bug#29296] [PATCH 2/2] gexp: Add 'let-system'. Resent-Message-ID: References: <20171114162515.8743-1-ludo@gnu.org> <20171114162515.8743-2-ludo@gnu.org> From: Mathieu Othacehe In-reply-to: <20171114162515.8743-2-ludo@gnu.org> Date: Wed, 15 Nov 2017 12:27:16 +0100 Message-ID: <87fu9fsrxn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 29296@debbugs.gnu.org Hi Ludo, I must admit i don't have a perfect understanding of what is going on in gexp.scm but your serie LGTM. When diffing with the initial patch it seems that the entry in .dir-locals.el is gone but it is a minor point. About the integration of let-system in "system-disk-image", i'm not sure how to proceed. let-system is meant to be used in a gexp but the operating-system is not defined in a gexp. Do you have any advice on how to turn os declaration into a gexp so that i can use let-system to parameterize kernel field ? Thanks, Mathieu