From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQFRV-00089P-FZ for guix-patches@gnu.org; Sat, 16 Dec 2017 11:36:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQFRS-0002bx-Bj for guix-patches@gnu.org; Sat, 16 Dec 2017 11:36:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:57102) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eQFRS-0002bh-8M for guix-patches@gnu.org; Sat, 16 Dec 2017 11:36:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eQFRR-0005Kr-Qs for guix-patches@gnu.org; Sat, 16 Dec 2017 11:36:02 -0500 Subject: [bug#29359] [PATCH 20/31] gnu: Add java-xpp3. Resent-Message-ID: References: <20171119175805.902-1-julien@lepiller.eu> <20171119175805.902-20-julien@lepiller.eu> From: Ricardo Wurmus In-reply-to: <20171119175805.902-20-julien@lepiller.eu> Date: Sat, 16 Dec 2017 17:34:43 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <87fu8aocm4.fsf@elephly.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Julien Lepiller Cc: 29359@debbugs.gnu.org Julien Lepiller writes: > * gnu/packages/java.scm (java-xpp3): New variable. Please move it to xml.scm. [=E2=80=A6] > + (modify-phases %standard-phases > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((out (string-append (assoc-ref outputs "out") "/share= /java"))) > + (mkdir-p out) > + (copy-file (string-append "build/xpp3-" ,version ".jar") > + (string-append out "/xpp3.jar"))) > + #t))))) Same as for java-xmlpull2: please use =E2=80=9Cinstall-jars=E2=80=9D, if po= ssible. > + (home-page "http://www.extreme.indiana.edu/xgws/xsoap/xpp/") > + (synopsis "Streaming pull XML parser") > + (description "Xml Pull Parser (in short XPP) is a streaming pull XML > +parser and should be used when there is a need to process quickly and > +efficiently all input elements (for example in SOAP processors).") Please capitalize =E2=80=9CXml=E2=80=9D. How does this differ from java-xm= lpull2? Could you come up with a better description maybe? (AIUI java-xmlpull2 is in maintenance mode, so it may be worth adding that information to the package description.) > + (license license:public-domain))) Where did you find the public domain declaration? I only see this BSD-4 variant, which means this should be (license:non-copyleft "file://LICENSE.txt"). -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net