From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#30641: Make 'guix refresh' to ignore "v" prefix in CPAN updater Date: Thu, 01 Mar 2018 14:58:04 +0100 Message-ID: <87fu5j6gpf.fsf@gnu.org> References: <20180128184437.32296-1-go.wigust@gmail.com> <87a7wxrdop.fsf@gmail.com> <87vaep9kg0.fsf@fastmail.com> <87o9kgkchr.fsf@gmail.com> <87h8q89e15.fsf@fastmail.com> <87vaemgv37.fsf@gmail.com> <87tvu68c74.fsf@fastmail.com> <87r2p5g8vp.fsf_-_@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:51688) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erOjj-0003KT-Qb for bug-guix@gnu.org; Thu, 01 Mar 2018 08:59:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erOje-0003ki-UQ for bug-guix@gnu.org; Thu, 01 Mar 2018 08:59:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:58675) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1erOje-0003jG-Qt for bug-guix@gnu.org; Thu, 01 Mar 2018 08:59:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1erOje-0000AZ-Il for bug-guix@gnu.org; Thu, 01 Mar 2018 08:59:02 -0500 Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Message-ID: In-Reply-To: <87r2p5g8vp.fsf_-_@gmail.com> (Oleg Pykhalov's message of "Wed, 28 Feb 2018 05:12:26 +0300") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Oleg Pykhalov Cc: 30641-done@debbugs.gnu.org Hi, Oleg Pykhalov skribis: > Marius Bakke writes: > >> Oleg Pykhalov writes: >> >>> Marius Bakke writes: >>> >>>> Sorry, I meant the opposite: we don't add the "v" prefix. It would be >>>> nice to make the CPAN updater aware of that. >>> >>> I'll close current bug report. Should we open a new one for CPAN >>> updater fix purpose? > > Sounds good! I think the GitHub updater already ignores the "v" prefix > when comparing versions, so there might be some inspiration there. > >>>>> I see a bunch of packages packages have "v" prefix: >>>>> --8<---------------cut here---------------start------------->8--- >>>>> ./gnu/packages/perl.scm:3599: (version "v2.49.1") >>>>> ./gnu/packages/perl.scm:7969: (version "v0.0.2") >>>>> ./gnu/packages/perl.scm:8697: (version "v0.2.13") >>>>> ./gnu/packages/networking.scm:778: (version "v0.003") >>>>> ./gnu/packages/mail.scm:1755: (version "v2.9.0") >>>>> --8<---------------cut here---------------end--------------->8--- >>>> >>>> Let's fix these :-) >>> >>> I guess it's better to do after a CPAN updater fix. WDYT? > > No opinion either way :-) Could you fix these? > Example of =E2=80=98guix refresh=E2=80=99 [2] wants to upgrade a package = with the same > version because of =E2=80=98v=E2=80=99 prefix: > > /home/natsu/src/guix-wip-licensecheck/gnu/packages/license.scm:108:2: lic= ensecheck 3.0.31: can be upgraded to v3.0.31 That turned out to be easy to fix, done in b402f4ee34d35f9b934b5449d2cc419dc287895e. Thanks, Ludo=E2=80=99.