From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1esxkF-0000lt-V5 for guix-patches@gnu.org; Mon, 05 Mar 2018 16:34:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1esxkA-0006pu-Ue for guix-patches@gnu.org; Mon, 05 Mar 2018 16:34:07 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:38448) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1esxkA-0006pq-Qh for guix-patches@gnu.org; Mon, 05 Mar 2018 16:34:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1esxkA-0008Jj-Ie for guix-patches@gnu.org; Mon, 05 Mar 2018 16:34:02 -0500 Subject: [bug#30701] [PATCH 1/3] services: Rework the PostgreSQL config file to use a record type. Resent-Message-ID: References: <87po4jpsgc.fsf@cbaines.net> <20180305193719.28652-1-mail@cbaines.net> From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur In-reply-to: <20180305193719.28652-1-mail@cbaines.net> Date: Mon, 05 Mar 2018 22:33:49 +0100 Message-ID: <87fu5eyzpe.fsf@lassieur.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 30701@debbugs.gnu.org Christopher Baines writes: > For the default config file representation. This makes it possible to more > easily change the configuration file, and have dynamic content. In particular, > I'm looking at adding a pid file location to the config file. ^ Could you please remove this last sentence (with the pid file)? > * gnu/services/databases.scm (): New record type. > (%default-postgres-config): Remove this, it's been replaced by the > configuration file. > (): Alter the default for the config file field. > (postgresql-service): Alter the default value for the config-file parameter. > --- > gnu/services/databases.scm | 86 +++++++++++++++++++++++++++++++++++----------- > 1 file changed, 66 insertions(+), 20 deletions(-) > > diff --git a/gnu/services/databases.scm b/gnu/services/databases.scm > index 3ca8f471f..f7d5fffd0 100644 > --- a/gnu/services/databases.scm > +++ b/gnu/services/databases.scm > @@ -26,11 +26,20 @@ > #:use-module (gnu system shadow) > #:use-module (gnu packages admin) > #:use-module (gnu packages databases) > + #:use-module (guix store) I don't think (guix store) is used. Is it? > #:use-module (guix modules) > #:use-module (guix records) > #:use-module (guix gexp) ... > + `(("log_destination" ,@(with-single-quotes log-destination)) > + ("hba_file" ,@(with-single-quotes hba-file)) > + ("ident_file" ,@(with-single-quotes ident-file)) ^ Could you please use a shorter name? Like "enclose", so that we won't go over 80 columns too easily :-). Apart from those small things, the three patches LGTM. Thank you again! Clément