From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59011)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1exMIM-00065R-E8
	for guix-patches@gnu.org; Sat, 17 Mar 2018 20:35:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1exMHv-0005iS-4X
	for guix-patches@gnu.org; Sat, 17 Mar 2018 20:35:30 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:59210)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1exMHu-0005ho-TX
	for guix-patches@gnu.org; Sat, 17 Mar 2018 20:35:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1exMHu-0001j0-EM
	for guix-patches@gnu.org; Sat, 17 Mar 2018 20:35:02 -0400
Subject: [bug#30701] [PATCH 1/3] services: Rework the PostgreSQL config file
	to use a record type.
Resent-Message-ID: <handler.30701.D30701.15213332996618@debbugs.gnu.org>
References: <87po4jpsgc.fsf@cbaines.net>
	<20180305193719.28652-1-mail@cbaines.net> <87fu5eyzpe.fsf@lassieur.org>
	<87605z27xh.fsf@cbaines.net> <87o9jqtv6j.fsf@lassieur.org>
	<87605ujv9k.fsf@cbaines.net>
From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
In-reply-to: <87605ujv9k.fsf@cbaines.net>
Date: Sun, 18 Mar 2018 01:34:48 +0100
Message-ID: <87fu4yfcgn.fsf@lassieur.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 30701-done@debbugs.gnu.org

Christopher Baines <mail@cbaines.net> writes:

> Clément Lassieur <clement@lassieur.org> writes:
>
>> Christopher Baines <mail@cbaines.net> writes:
>>
>>> Sorry, I made some changes, and merged these patches on the weekend, but
>>> I forgot to reply.
>>
>> [...]
>>
>>>>> +        `(("log_destination" ,@(with-single-quotes log-destination))
>>>>> +          ("hba_file" ,@(with-single-quotes hba-file))
>>>>> +          ("ident_file" ,@(with-single-quotes ident-file))
>>>>                                     ^
>>>> Could you please use a shorter name?  Like "enclose", so that we won't
>>>> go over 80 columns too easily :-).
>>>
>>> I went with quote' as I think that works well.
>>
>> I don't like it because:
>>
>>   • The extra \' doesn't help describing what the function does.  One
>>     could believe it's a variant of 'quote', but it's actually very
>>     different.
>>
>>   • It doesn't follow our coding style.  See
>>     https://mumble.net/~campbell/scheme/style.txt.  "Symbolic names are
>>     written with English words separated by hyphens."  See also the part
>>     about "Funny Characters".
>
> Fair enough, I've changed it to single-quote in
> 533808383f7fca6563aee1452f5202e0cd1b66b8.

Thank you Christopher!