From: "Clément Lassieur" <clement@lassieur.org>
To: Christopher Baines <mail@cbaines.net>
Cc: 30701-done@debbugs.gnu.org
Subject: [bug#30701] [PATCH 1/3] services: Rework the PostgreSQL config file to use a record type.
Date: Sun, 18 Mar 2018 01:34:48 +0100 [thread overview]
Message-ID: <87fu4yfcgn.fsf@lassieur.org> (raw)
In-Reply-To: <87605ujv9k.fsf@cbaines.net>
Christopher Baines <mail@cbaines.net> writes:
> Clément Lassieur <clement@lassieur.org> writes:
>
>> Christopher Baines <mail@cbaines.net> writes:
>>
>>> Sorry, I made some changes, and merged these patches on the weekend, but
>>> I forgot to reply.
>>
>> [...]
>>
>>>>> + `(("log_destination" ,@(with-single-quotes log-destination))
>>>>> + ("hba_file" ,@(with-single-quotes hba-file))
>>>>> + ("ident_file" ,@(with-single-quotes ident-file))
>>>> ^
>>>> Could you please use a shorter name? Like "enclose", so that we won't
>>>> go over 80 columns too easily :-).
>>>
>>> I went with quote' as I think that works well.
>>
>> I don't like it because:
>>
>> • The extra \' doesn't help describing what the function does. One
>> could believe it's a variant of 'quote', but it's actually very
>> different.
>>
>> • It doesn't follow our coding style. See
>> https://mumble.net/~campbell/scheme/style.txt. "Symbolic names are
>> written with English words separated by hyphens." See also the part
>> about "Funny Characters".
>
> Fair enough, I've changed it to single-quote in
> 533808383f7fca6563aee1452f5202e0cd1b66b8.
Thank you Christopher!
prev parent reply other threads:[~2018-03-18 0:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 19:10 [bug#30701] [PATCH 0/4] PostgreSQL service changes (add record type, and system test) Christopher Baines
2018-03-04 19:16 ` [bug#30701] [PATCH 1/4] services: Rework the PostgreSQL config file to use a record type Christopher Baines
2018-03-04 19:16 ` [bug#30701] [PATCH 2/4] services: Use a external pid file for PostgreSQL Christopher Baines
2018-03-05 0:32 ` Clément Lassieur
2018-03-05 8:21 ` Christopher Baines
2018-03-05 8:27 ` Christopher Baines
2018-03-05 12:15 ` Clément Lassieur
2018-03-04 19:16 ` [bug#30701] [PATCH 3/4] tests: databases: Add a system test " Christopher Baines
2018-03-05 0:32 ` Clément Lassieur
2018-03-05 8:34 ` Christopher Baines
2018-03-04 19:16 ` [bug#30701] [PATCH 4/4] services: databases: Add postgresql-configuration record exports Christopher Baines
2018-03-05 12:16 ` Clément Lassieur
2018-03-05 19:37 ` Christopher Baines
2018-03-05 0:32 ` [bug#30701] [PATCH 1/4] services: Rework the PostgreSQL config file to use a record type Clément Lassieur
2018-03-05 7:52 ` Christopher Baines
2018-03-05 8:52 ` Clément Lassieur
2018-03-05 9:35 ` Clément Lassieur
2018-03-05 8:39 ` [bug#30701] [PATCH 1/3] " Christopher Baines
2018-03-05 8:39 ` [bug#30701] [PATCH 2/3] tests: databases: Add a system test for PostgreSQL Christopher Baines
2018-03-05 11:54 ` Clément Lassieur
2018-03-05 19:25 ` Christopher Baines
2018-03-05 8:39 ` [bug#30701] [PATCH 3/3] services: databases: Add postgresql-configuration record exports Christopher Baines
2018-03-05 19:37 ` [bug#30701] [PATCH 1/3] services: Rework the PostgreSQL config file to use a record type Christopher Baines
2018-03-05 19:37 ` [bug#30701] [PATCH 2/3] tests: databases: Add a system test for PostgreSQL Christopher Baines
2018-03-05 19:37 ` [bug#30701] [PATCH 3/3] services: databases: Add postgresql-configuration record exports Christopher Baines
2018-03-05 21:33 ` [bug#30701] [PATCH 1/3] services: Rework the PostgreSQL config file to use a record type Clément Lassieur
2018-03-13 17:37 ` bug#30701: " Christopher Baines
2018-03-14 17:37 ` [bug#30701] " Clément Lassieur
2018-03-17 20:35 ` Christopher Baines
2018-03-18 0:34 ` Clément Lassieur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fu4yfcgn.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=30701-done@debbugs.gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.