From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fAXz6-0002VE-AT for guix-patches@gnu.org; Mon, 23 Apr 2018 05:42:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fAXz0-0006ue-AW for guix-patches@gnu.org; Mon, 23 Apr 2018 05:42:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56834) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fAXz0-0006uW-6c for guix-patches@gnu.org; Mon, 23 Apr 2018 05:42:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fAXyz-00026o-QD for guix-patches@gnu.org; Mon, 23 Apr 2018 05:42:01 -0400 Subject: [bug#31237] [PATCH] gnu: Add runc. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180422125844.15227-1-iyzsong@member.fsf.org> <877eoygahy.fsf@gnu.org> <20180422230603.gm2u5637w3rkdpvc@abyayala> <87vacizjr4.fsf@member.fsf.org> Date: Mon, 23 Apr 2018 11:41:41 +0200 In-Reply-To: <87vacizjr4.fsf@member.fsf.org> ("=?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?="'s message of "Mon, 23 Apr 2018 11:25:51 +0800") Message-ID: <87fu3m45uy.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Cc: Nils Gillmann , 31237@debbugs.gnu.org Hello, iyzsong@member.fsf.org (=E5=AE=8B=E6=96=87=E6=AD=A6) skribis: > No I haven't, some fails are: > > --- FAIL: TestFactoryNewTmpfs (0.00s) > factory_linux_test.go:87: operation not permitted > > FAIL github.com/opencontainers/runc/libcontainer 0.047s > ? github.com/opencontainers/runc/libcontainer/apparmor [no test files] > > --- FAIL: TestInvalidCgroupPath (0.00s) > apply_raw_test.go:16: couldn't get cgroup root: mountpoint for cgroup no= t found > apply_raw_test.go:25: couldn't get cgroup data: mountpoint for cgroup no= t found > panic: runtime error: invalid memory address or nil pointer dereference [= recovered] > > --- FAIL: TestValidateRootlessMountUid (0.00s) > rootless_test.go:96: Expected error to not occur when uid=3D not set in = mount options: rootfs (/var) does not exist > rootless_test.go:106: Expected error to not occur when setting uid=3D0 i= n mount options: rootfs (/var) does not exist > rootless_test.go:112: Expected error to not occur when setting uid=3D2 i= n mount options and UidMapping[0].size is 10 > > --- FAIL: TestValidateValidSysctl (0.00s) > validator_test.go:229: Expected error to not occur with {net.ctl=3Dctl} = but got: "rootfs (/var) does not exist" > validator_test.go:229: Expected error to not occur with {kernel.msgmax= =3Dctl} but got: "rootfs (/var) does not exist" > validator_test.go:229: Expected error to not occur with {fs.mqueue.ctl= =3Dctl} but got: "rootfs (/var) does not exist" > > --- FAIL: TestNsenterValidPaths (0.01s) > nsenter_test.go:65: nsenter exits with a non-zero exit status > > > Look like it need /var, network namespace and other things? But thoes > are unittest (runc also has integrationtest target)... Need more > investment. Right. For now I think we could skip all the tests above, with a comment explaining the reason (/var, cgroups, and apparmor unavailable in the build environment.) Thank you! Ludo=E2=80=99.